From owner-cvs-all@FreeBSD.ORG  Thu Oct  5 15:39:00 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5A1C416A403;
	Thu,  5 Oct 2006 15:39:00 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2B3B943D45;
	Thu,  5 Oct 2006 15:39:00 +0000 (GMT) (envelope-from jhb@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k95Fd0VI011203;
	Thu, 5 Oct 2006 15:39:00 GMT (envelope-from jhb@repoman.freebsd.org)
Received: (from jhb@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k95Fd02U011202;
	Thu, 5 Oct 2006 15:39:00 GMT (envelope-from jhb)
Message-Id: <200610051539.k95Fd02U011202@repoman.freebsd.org>
From: John Baldwin <jhb@FreeBSD.org>
Date: Thu, 5 Oct 2006 15:38:59 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/sys/dev/ipmi ipmi_smic.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Oct 2006 15:39:00 -0000

jhb         2006-10-05 15:38:59 UTC

  FreeBSD src repository

  Modified files:
    sys/dev/ipmi         ipmi_smic.c 
  Log:
  The IPMI spec is ambiguous (or rather, it contradicts itself) about whether
  or not the OS has to wait for RX_RDY or TX_RDY to be set before the OS sets
  the control code in the control/status register.  Looking at the interface
  design, it seems that RX_RDY and TX_RDY are probably there to protect
  access to the data register and have nothing to do with the control/status
  register.  Nevertheless, try to take what I think is the more conservative
  approach and always wait for the appropriate [TR]X_RDY flag to be set
  before writing any of the WR_NEXT, WR_END, RD_START, or RD_NEXT control
  codes to the control/status register.
  
  Revision  Changes    Path
  1.4       +4 -4      src/sys/dev/ipmi/ipmi_smic.c