From owner-cvs-all Sat Jul 15 8:22:41 2000 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 10A4537B623; Sat, 15 Jul 2000 08:22:35 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.8.7/8.8.7) with ESMTP id BAA00948; Sun, 16 Jul 2000 01:22:15 +1000 Date: Sun, 16 Jul 2000 01:22:09 +1000 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Paul Saab Cc: Warner Losh , Paul Saab , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 trap.c In-Reply-To: <20000714122507.A10475@elvis.mu.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Fri, 14 Jul 2000, Paul Saab wrote: > Warner Losh (imp@village.org) wrote: > > In message <200007141149.EAA96783@freefall.freebsd.org> Paul Saab writes: > > : This will solve the problem with having DDB enabled and getting an > > : NMI due to some possibly bad error and being able to continue the > > : operation of the kernel when you really want to panic and know > > : what happened. > > > > Does this work on all motherboards? Steve Passe wrote similar code a > > long time ago, which i dusted off and tried to submit. Both Steve and > > bde were worried that it was too motherboard and/or chipset dependent. As Steve mentioned, his code was for a different problem. However, the NMI decoding code may be too machine-dependent to rely on. I think isa_nmi() should be changed to just print a message and return status (or to return a string giving the message). Then the caller can panic as required (never panic immediately if DDB is configured). Note that the panic after the first isa_nmi() in trap.c is bogus. isa_nmi() never returns nonzero. It panics instead. The FALLTHROUGH after the second isa_nmi() trap.c is bogus for the same reason. trap_fatal() would print more information about the context, but is never reached. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message