Date: Wed, 22 Aug 2012 08:02:14 -0400 From: John Baldwin <jhb@freebsd.org> To: freebsd-hackers@freebsd.org Cc: Wojciech Puchar <wojtek@wojtek.tensor.gdynia.pl>, Adrian Chadd <adrian@freebsd.org>, Mitya <mitya@cabletv.dp.ua>, Warner Losh <imp@bsdimp.com>, freebsd-net@freebsd.org Subject: Re: Replace bcopy() to update ether_addr Message-ID: <201208220802.14588.jhb@freebsd.org> In-Reply-To: <CAJ-VmokQLD6YgyrsOyez=3cLm4Q8jZOnJ9vo4Wq3sjRu%2BG-E7A@mail.gmail.com> References: <50324DB4.6080905@cabletv.dp.ua> <420BA06C-C776-47DB-B3BB-F1414C115F99@bsdimp.com> <CAJ-VmokQLD6YgyrsOyez=3cLm4Q8jZOnJ9vo4Wq3sjRu%2BG-E7A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, August 21, 2012 12:34:42 pm Adrian Chadd wrote: > Hi, > > What about just creating an ETHER_ADDR_COPY(dst, src) and putting that > in a relevant include file, then hide the ugliness there? > > The same benefits will likely appear when copying wifi MAC addresses > to/from headers. > > Thanks, I'm glad someone noticed this. I doubt we even _need_ the ugliness. We should just use *dst = *src unless there is a compelling reason not to. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201208220802.14588.jhb>