From owner-svn-src-all@freebsd.org Fri Nov 16 23:10:49 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A78781107487; Fri, 16 Nov 2018 23:10:49 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A647E6DB81; Fri, 16 Nov 2018 23:10:48 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 1D0723C475F; Fri, 16 Nov 2018 23:10:47 +0000 (UTC) Date: Fri, 16 Nov 2018 23:10:47 +0000 From: Brooks Davis To: Jan Beich Cc: Brooks Davis , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r338990 - in head/sys: compat/freebsd32 dev/pci Message-ID: <20181116231047.GA94365@spindle.one-eyed-alien.net> References: <201809272108.w8RL8Xqn052122@repo.freebsd.org> <7ehc-y6sm-wny@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CE+1k2dSO48ffgeK" Content-Disposition: inline In-Reply-To: <7ehc-y6sm-wny@FreeBSD.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Queue-Id: A647E6DB81 X-Spamd-Result: default: False [-4.53 / 15.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[freebsd.org]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[5]; IP_SCORE(-3.62)[ip: (-9.40), ipnet: 199.48.128.0/22(-4.70), asn: 36236(-3.92), country: US(-0.10)]; MX_GOOD(-0.01)[cached: spindle.one-eyed-alien.net]; R_SPF_NA(0.00)[]; SIGNED_PGP(-2.00)[]; FORGED_SENDER(0.30)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:36236, ipnet:199.48.128.0/22, country:US]; FROM_NEQ_ENVFROM(0.00)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Nov 2018 23:10:50 -0000 --CE+1k2dSO48ffgeK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 16, 2018 at 11:52:09PM +0100, Jan Beich wrote: > Brooks Davis writes: >=20 > > Author: brooks > > Date: Thu Sep 27 21:08:32 2018 > > New Revision: 338990 > > URL: https://svnweb.freebsd.org/changeset/base/338990 > > > > Log: > > Centralize compat support for PCIOCGETCONF. > > =20 > > The pre-7.x compat for both native and 32-bit code was already in > > pci_user.c. Use this infrastructure to add implement 32-bit support. > > This is more correct as ioctl(2) commands only have meaning in the > > context of a file descriptor. > > =20 > > Reviewed by: kib > > Approved by: re (gjb) > > Obtained from: CheriBSD > > Sponsored by: DARPA, AFRL > > Differential revision: https://reviews.freebsd.org/D17324 >=20 > After this commit getdevice() from pciconf(8) and pci_find_conf() in > tools/tools/dmardump/dmardump.c always fail in EPERM in -m32 mode. > Found via graphics/libdrm where PCIOCGETCONF is used to get a list of > DRM devices for use by OpenGL/Vulkan/VAAPI userland drivers. >=20 > Can you fix the regression before 12.0R or back the commit out? >=20 > https://lists.freebsd.org/pipermail/freebsd-current/2018-November/072144.= html Eeek, looks like I missed a case statment in a switch that I somehow didn't hit in testing. I'm building a potential fix now. -- Brooks --CE+1k2dSO48ffgeK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJb7052AAoJEKzQXbSebgfA0MgH/3C9SUppFZABfuIFrj09Ez6K D+C5RqEpnaD3HordXoGCkS/drfyacO1S0KOBkDqikXmQfOalOlBUti1kDmf03puy G8GMfZL+LEOYxcX/rTlD47lmECt+iB6NTkXXixFKduixjj6bVBTU8ABcrq2iYHzf 115uieGyRAZtAcRA8gq4+6/cWephH+H40hPK9um6i3cR8CLRehPe318DMlHecrXL ZVdxkSwXc3S7nB/0Jy/s0w5C2OR33i8LFmb/nRn6MRRptcWLkfhd4SDTUUpknvpr ip/sSY3CK5vL99UDhMg9ap2510h6Ls8nxPf6x3Co6MKZ9iM7VuIYiALoDv3+Ebg= =yY6t -----END PGP SIGNATURE----- --CE+1k2dSO48ffgeK--