From owner-cvs-all@FreeBSD.ORG Wed Sep 1 21:12:03 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2ED0A16A4CE; Wed, 1 Sep 2004 21:12:03 +0000 (GMT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 108DF43D45; Wed, 1 Sep 2004 21:12:03 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id i81LCQF9007992; Wed, 1 Sep 2004 14:12:26 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id i81LCQfF007991; Wed, 1 Sep 2004 14:12:26 -0700 Date: Wed, 1 Sep 2004 14:12:26 -0700 From: Brooks Davis To: "Justin T. Gibbs" Message-ID: <20040901211226.GB3754@odin.ac.hmc.edu> References: <200409011822.i81IMERb017602@repoman.freebsd.org> <73F8DDC079929FAA3D43CA2E@caspian.scsiguy.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OwLcNYc0lM97+oe1" Content-Disposition: inline In-Reply-To: <73F8DDC079929FAA3D43CA2E@caspian.scsiguy.com> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu cc: cvs-src@FreeBSD.org cc: Brooks Davis cc: cvs-all@FreeBSD.org cc: src-committers@FreeBSD.org Subject: Re: cvs commit: src/sbin/ifconfig ifconfig.c src/sys/net if.c if.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Sep 2004 21:12:03 -0000 --OwLcNYc0lM97+oe1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 01, 2004 at 02:44:45PM -0600, Justin T. Gibbs wrote: >=20 > > brooks 2004-09-01 18:22:14 UTC > >=20 > > FreeBSD src repository > >=20 > > Modified files: > > sbin/ifconfig ifconfig.c=20 > > sys/net if.c if.h=20 > > Log: > > Use a spare byte in struct if_data to store the structure size without > > increasing it. Add code to ifconfig to use this size to find the > > sockaddr_dl after the struct if_data in the routing message. This > > allows struct if_data to grow (up to 255 bytes) without breaking > > ifconfig. >=20 > You could squeeze out 256 bytes if you treat 0 as meaning 256 - just like > the SCSI protocol. Unfortunaly, we're using 0 as the magic, not-set variable. My intent is to add some better hurristics for the 0 case if we do end up keeping this hack. Long term, we probably need to rev the routing message API to fix this kind of junk, but that's a massive undertaking. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --OwLcNYc0lM97+oe1 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFBNjs5XY6L6fI4GtQRAgAIAJ92UwkD6gXAURy3ZcS9RhzpLkpaawCgj9Sx DF3+6mmlXige+lWc1MHwn70= =ekhs -----END PGP SIGNATURE----- --OwLcNYc0lM97+oe1--