From owner-svn-src-all@freebsd.org Fri Aug 12 00:26:17 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B7CA1BB5D2D; Fri, 12 Aug 2016 00:26:17 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 906FB17C0; Fri, 12 Aug 2016 00:26:17 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id 838741ABE; Fri, 12 Aug 2016 00:26:17 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 3FC41212DF; Fri, 12 Aug 2016 00:26:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id RcK5y7UOQU9A; Fri, 12 Aug 2016 00:26:13 +0000 (UTC) Subject: Re: svn commit: r303019 - head/sys/geom DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com D4729212DA To: Peter Wemm , svn-src-all@freebsd.org References: <201607190536.u6J5aLl7015268@repo.freebsd.org> <3277576.dFZ2EGo2Fh@overcee.wemm.org> <6198652.UmU69kS6Zt@overcee.wemm.org> Cc: svn-src-head@freebsd.org, "Andrey V. Elsukov" , src-committers@freebsd.org From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <181fcc35-3a5d-043f-7dc4-7a01a53eebae@FreeBSD.org> Date: Thu, 11 Aug 2016 17:26:10 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <6198652.UmU69kS6Zt@overcee.wemm.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BJhoLgMkksH5EckaHRAj2DQh0ovuEgcBq" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Aug 2016 00:26:17 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BJhoLgMkksH5EckaHRAj2DQh0ovuEgcBq Content-Type: multipart/mixed; boundary="p6ApadA0NaQUCkFPEEw0Q9Wi9nIlAKWS5" From: Bryan Drewery To: Peter Wemm , svn-src-all@freebsd.org Cc: svn-src-head@freebsd.org, "Andrey V. Elsukov" , src-committers@freebsd.org Message-ID: <181fcc35-3a5d-043f-7dc4-7a01a53eebae@FreeBSD.org> Subject: Re: svn commit: r303019 - head/sys/geom References: <201607190536.u6J5aLl7015268@repo.freebsd.org> <3277576.dFZ2EGo2Fh@overcee.wemm.org> <6198652.UmU69kS6Zt@overcee.wemm.org> In-Reply-To: <6198652.UmU69kS6Zt@overcee.wemm.org> --p6ApadA0NaQUCkFPEEw0Q9Wi9nIlAKWS5 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 7/23/2016 10:27 PM, Peter Wemm wrote: > On Saturday, July 23, 2016 09:39:00 PM Peter Wemm wrote: >> On Tuesday, July 19, 2016 05:36:21 AM Andrey V. Elsukov wrote: >>> Author: ae >>> Date: Tue Jul 19 05:36:21 2016 >>> New Revision: 303019 >>> URL: https://svnweb.freebsd.org/changeset/base/303019 >>> >>> Log: >>> Use g_resize_provider() to change the size of GEOM_DISK provider, >>> when it is being opened. This should fix the possible loss of a res= ize >>> event when disk capacity changed. >> >> Are you sure about this? We have machines in the freebsd.org cluster = that >> now panic on boot: >> >> Trying to mount root from zfs:zroot []... >> GEOM_PART: da0 was automatically resized. >> Use `gpart commit da0` to save changes or `gpart undo da0` to revert= them. >> GEOM_PART: integrity check failed (da0, GPT) >> >> Fatal trap 12: page fault while in kernel mode >> cpuid =3D 1; apic id =3D 01 >> fault virtual address =3D 0x48 >> fault code =3D supervisor read data, page not present >> instruction pointer =3D 0x20:0xffffffff80740005 >> stack pointer =3D 0x28:0xfffffe01f119db10 >> frame pointer =3D 0x28:0xfffffe01f119db30 >> code segment =3D base 0x0, limit 0xfffff, type 0x1b >> =3D DPL 0, pres 1, long 1, def32 0, gran 1 >> processor eflags =3D interrupt enabled, resume, IOPL =3D 0 >> current process =3D 13 (g_event) >> [ thread pid 13 tid 100019 ] >> Stopped at g_part_resize+0x35: testb $0x8,0x48(%rbx) >> >> >> >> db> where >> Tracing pid 13 tid 100019 td 0xfffff8000426fa00 >> g_part_resize() at g_part_resize+0x35/frame 0xfffffe01f119db30 >> g_resize_provider_event() at g_resize_provider_event+0xb5/frame >> 0xfffffe01f119d0 g_run_events() at g_run_events+0x20e/frame >> 0xfffffe01f119dbb0 >> .. >> >> It is exploding here: >> g_part_resize(struct g_consumer *cp) >> { >> struct g_part_table *table; >> >> G_PART_TRACE((G_T_TOPOLOGY, "%s(%s)", __func__, >> cp->provider->name)); g_topology_assert(); >> >> table =3D cp->geom->softc; >> if (table->gpt_opened =3D=3D 0) { >> ^^^^^^^^^ (table is null) >> >> Are you creating events too soon now? >=20 > Sometimes da0 fails, other times da1 fails.. and sometimes it is comple= tely=20 > fine. There is some sort of race going on with this change during the = very=20 > first moments of bootup. >=20 On r303467 I ran into this: panic @ time 1470916206.652, thread 0xfffff8000412f000: g_resize_provider_event but withered cpuid =3D 0 Panic occurred in module kernel loaded at 0xffffffff80200000: Stack: -------------------------------------------------- kernel:kassert_panic+0x166 kernel:g_resize_provider_event+0x181 kernel:g_run_events+0x186^M^M kernel:fork_exit+0x83^M^M -------------------------------------------------- No further information available unfortunately. --=20 Regards, Bryan Drewery --p6ApadA0NaQUCkFPEEw0Q9Wi9nIlAKWS5-- --BJhoLgMkksH5EckaHRAj2DQh0ovuEgcBq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJXrReiAAoJEDXXcbtuRpfPwCcH/jaBBL75tTHMdt/WfkRLfZyq S49GZcoF4WdHcyWa5nvNYtAXHAcLfpNc9MyZsl5Vbjr/e3tv9V8b9KMzyELp3/+5 0Jyxx60NO+1jHHFYJkQs5kR7jiiixVaesIuVa+dspR3qiqJHDinxWmR2+pfFpp4U ggUB3VodjUlLb9Gs2g71WdJ+J+1bupttpLqHAJJTbi5mxVPIrQNQ5gFT0a+txWif 0g5BJuZnB7vrCuCKgnBm50eNnw4tzyAhhzXyRZ2TaV1v7xvAgsN1DlWdpXUWeCBH +WrxnYfdA5+nPCNnTsC8ONtsyUIeEQJQPAYCkmV4T88/NtTijM7rtedFVHKXJSA= =I2Cf -----END PGP SIGNATURE----- --BJhoLgMkksH5EckaHRAj2DQh0ovuEgcBq--