Date: Sun, 1 Feb 2015 16:28:16 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Bruce Evans <brde@optusnet.com.au> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r278004 - head/sys/dev/drm2/radeon Message-ID: <E037E6AD-32D1-43EC-BFE7-D580A2AD8C66@FreeBSD.org> In-Reply-To: <20150201153237.Q867@besplex.bde.org> References: <201501312218.t0VMIr7m035695@svn.freebsd.org> <20150201153237.Q867@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_55BEC5ED-C86D-4836-9F47-35B16CC5E65F Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 01 Feb 2015, at 06:00, Bruce Evans <brde@optusnet.com.au> wrote: > > On Sat, 31 Jan 2015, Dimitry Andric wrote: > >> Log: >> Constify a number of accesses in drm2's radeon drivers to avoid >> -Wcast-qual warnings. No functional change. > > This is much better than using __DECONST(), but still has bogus casts. ... > > Anyway, it is clearer to point to the > first element: > > io_mc_regs = &barts_io_mc_regs[0][0]; Thanks, I've put that up for review, here: https://reviews.freebsd.org/D1748 -Dimitry --Apple-Mail=_55BEC5ED-C86D-4836-9F47-35B16CC5E65F Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.26 iEYEARECAAYFAlTORhMACgkQsF6jCi4glqM3NwCeLTSFKvX2gnHwWJ3vZM5vpAYy NDYAn1eNWGEI6GipkgV4KkGhF1vSkqXE =lkrW -----END PGP SIGNATURE----- --Apple-Mail=_55BEC5ED-C86D-4836-9F47-35B16CC5E65F--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E037E6AD-32D1-43EC-BFE7-D580A2AD8C66>