From owner-svn-src-head@FreeBSD.ORG Sun Feb 1 15:28:23 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0061A1C5; Sun, 1 Feb 2015 15:28:22 +0000 (UTC) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AB223BE; Sun, 1 Feb 2015 15:28:22 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::2844:fbf7:162f:3ca] (unknown [IPv6:2001:7b8:3a7:0:2844:fbf7:162f:3ca]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 9669A5C2E; Sun, 1 Feb 2015 16:28:17 +0100 (CET) Subject: Re: svn commit: r278004 - head/sys/dev/drm2/radeon Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_55BEC5ED-C86D-4836-9F47-35B16CC5E65F"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.5b4 (755500a+) From: Dimitry Andric In-Reply-To: <20150201153237.Q867@besplex.bde.org> Date: Sun, 1 Feb 2015 16:28:16 +0100 Message-Id: References: <201501312218.t0VMIr7m035695@svn.freebsd.org> <20150201153237.Q867@besplex.bde.org> To: Bruce Evans X-Mailer: Apple Mail (2.2070.6) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Feb 2015 15:28:23 -0000 --Apple-Mail=_55BEC5ED-C86D-4836-9F47-35B16CC5E65F Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 01 Feb 2015, at 06:00, Bruce Evans wrote: > > On Sat, 31 Jan 2015, Dimitry Andric wrote: > >> Log: >> Constify a number of accesses in drm2's radeon drivers to avoid >> -Wcast-qual warnings. No functional change. > > This is much better than using __DECONST(), but still has bogus casts. ... > > Anyway, it is clearer to point to the > first element: > > io_mc_regs = &barts_io_mc_regs[0][0]; Thanks, I've put that up for review, here: https://reviews.freebsd.org/D1748 -Dimitry --Apple-Mail=_55BEC5ED-C86D-4836-9F47-35B16CC5E65F Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.26 iEYEARECAAYFAlTORhMACgkQsF6jCi4glqM3NwCeLTSFKvX2gnHwWJ3vZM5vpAYy NDYAn1eNWGEI6GipkgV4KkGhF1vSkqXE =lkrW -----END PGP SIGNATURE----- --Apple-Mail=_55BEC5ED-C86D-4836-9F47-35B16CC5E65F--