From owner-freebsd-current@FreeBSD.ORG  Fri Aug 29 11:14:16 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C91B016A4BF
	for <current@freebsd.org>; Fri, 29 Aug 2003 11:14:16 -0700 (PDT)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D930843FB1
	for <current@freebsd.org>; Fri, 29 Aug 2003 11:14:15 -0700 (PDT)
	(envelope-from robert@fledge.watson.org)
Received: from fledge.watson.org (localhost [127.0.0.1])
	by fledge.watson.org (8.12.9/8.12.9) with ESMTP id h7TIDjrO048079;
	Fri, 29 Aug 2003 14:13:46 -0400 (EDT)
	(envelope-from robert@fledge.watson.org)
Received: from localhost (robert@localhost)h7TIDjok048076;
	Fri, 29 Aug 2003 14:13:45 -0400 (EDT)
Date: Fri, 29 Aug 2003 14:13:45 -0400 (EDT)
From: Robert Watson <rwatson@freebsd.org>
X-Sender: robert@fledge.watson.org
To: Mike Jakubik <mikej@trigger.net>
In-Reply-To: <JCEIKJMCANNPGKFKGLKLCEGIDMAA.mikej@trigger.net>
Message-ID: <Pine.NEB.3.96L.1030829140816.47993A-100000@fledge.watson.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: Current <current@freebsd.org>
Subject: RE: buildworld failure
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Aug 2003 18:14:16 -0000


On Fri, 29 Aug 2003, Mike Jakubik wrote:

> > Depends on how much work is involved in fixing it, and what the negative
> > impact is of leaving it.  Do you know what the impact is?
> 
> 	I think the impact is more social. People will try to compile
> world and get failures. Specially people coming from the 4.x branch,
> where this sort of think never occurred. If this is the only thing
> preventing a clean makeworld with -O2, I think its worth taking a look
> at. 
> 
> 	I've been using freebsd since the 2.x days, I have always
> compiled world and ports with -O2, and never had any instability issues
> due to the optimizations. I have switched back to -O and
> -march=pentium4, the buildworld finished ok. 

Well, it looks to me like the pam_echo code is correct, although I'm
willing to admit I'm not a expert in the code in question -- it's just not
optimizable to the desired level of optimization due to the interfaces
used.  As such, the real problem is either than the warning is generated,
or that the warning causes a build failure... 

Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org      Network Associates Laboratories