From owner-svn-src-head@freebsd.org  Sat Jan  7 15:57:13 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 95C57CA46DA;
 Sat,  7 Jan 2017 15:57:13 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 662581E92;
 Sat,  7 Jan 2017 15:57:13 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v07FvCVI063156;
 Sat, 7 Jan 2017 15:57:12 GMT (envelope-from dim@FreeBSD.org)
Received: (from dim@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id v07FvCUD063155;
 Sat, 7 Jan 2017 15:57:12 GMT (envelope-from dim@FreeBSD.org)
Message-Id: <201701071557.v07FvCUD063155@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: dim set sender to dim@FreeBSD.org
 using -f
From: Dimitry Andric <dim@FreeBSD.org>
Date: Sat, 7 Jan 2017 15:57:12 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r311649 - head/contrib/ngatm/snmp_atm
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Jan 2017 15:57:13 -0000

Author: dim
Date: Sat Jan  7 15:57:12 2017
New Revision: 311649
URL: https://svnweb.freebsd.org/changeset/base/311649

Log:
  Fix the following clang 4.0.0 warning in ngatm's snmp_atm.c:
  
      contrib/ngatm/snmp_atm/snmp_atm.c:173:6: error: logical not is only
      applied to the left hand side of this bitwise operator
      [-Werror,-Wlogical-not-parentheses]
              if (!ifmr.ifm_status & IFM_AVALID) {
                  ^                ~
  
  Obviously, the masking needs to be done before the logical not
  operation.  Add parentheses to make it so.
  
  MFC after:      3 days

Modified:
  head/contrib/ngatm/snmp_atm/snmp_atm.c

Modified: head/contrib/ngatm/snmp_atm/snmp_atm.c
==============================================================================
--- head/contrib/ngatm/snmp_atm/snmp_atm.c	Sat Jan  7 15:18:49 2017	(r311648)
+++ head/contrib/ngatm/snmp_atm/snmp_atm.c	Sat Jan  7 15:57:12 2017	(r311649)
@@ -170,7 +170,7 @@ atmif_check_carrier(struct atmif_priv *a
 		aif->pub.carrier = ATMIF_CARRIER_UNKNOWN;
 		return;
 	}
-	if (!ifmr.ifm_status & IFM_AVALID) {
+	if (!(ifmr.ifm_status & IFM_AVALID)) {
 		aif->pub.carrier = ATMIF_CARRIER_UNKNOWN;
 		return;
 	}