From owner-freebsd-hackers@FreeBSD.ORG Fri Apr 27 09:14:26 2012 Return-Path: Delivered-To: freebsd-hackers@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AD5A8106566B; Fri, 27 Apr 2012 09:14:26 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 577048FC15; Fri, 27 Apr 2012 09:14:25 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id MAA05309; Fri, 27 Apr 2012 12:14:23 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1SNhFv-0007XH-Gq; Fri, 27 Apr 2012 12:14:23 +0300 Message-ID: <4F9A6369.5060305@FreeBSD.org> Date: Fri, 27 Apr 2012 12:14:17 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:12.0) Gecko/20120425 Thunderbird/12.0 MIME-Version: 1.0 To: "Andrey V. Elsukov" References: <4F8999D2.1080902@FreeBSD.org> <20120422212102.GA66855@alchemy.franken.de> <4F94F56E.1010501@FreeBSD.org> In-Reply-To: <4F94F56E.1010501@FreeBSD.org> X-Enigmail-Version: 1.4 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Cc: freebsd-fs@FreeBSD.org, freebsd-hackers@FreeBSD.org, John Baldwin , Marius Strobl Subject: Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2012 09:14:26 -0000 on 23/04/2012 09:23 Andrey V. Elsukov said the following: > On 23.04.2012 1:21, Marius Strobl wrote: >> I can't say much about these patches as a whole as they are rather big >> and I'm not aware of all the details of ZFS. However, one bit that makes >> the current implementation x86-specific is zfs_dev_init(). If you could >> move it to the MD part in the course of these patches that would be >> great. If you could also take the second patch in PR 165025 into account, >> which I plan to commit once the issue with the current ofw_disk.c are >> properly solved, that would be great. > > I also have some WIP related to moving partition table handling into MD > part. You can look here: http://people.freebsd.org/~ae/sys_boot.diff I like this patch. OTOH, I couldn't help by wonder if it is possible to somehow directly re-use the results of dv_init probing by other drivers (or subset of the drivers, like only 'disk'). E.g. if instead of re-examining the partition tables, we could ask a driver for a list of devices that it discovered. But how to do that is not something that I can answer. > This patch have one problem, there is no way to determine disk size and i'm > thinking about adding ioctl(DIOCGMEDIASIZE) to the "disk" devsw. > -- Andriy Gapon