From owner-svn-src-all@FreeBSD.ORG  Thu Jul 15 12:04:23 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A22A8106567F;
	Thu, 15 Jul 2010 12:04:23 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from mail09.syd.optusnet.com.au (mail09.syd.optusnet.com.au
	[211.29.132.190])
	by mx1.freebsd.org (Postfix) with ESMTP id 19CE38FC1F;
	Thu, 15 Jul 2010 12:04:22 +0000 (UTC)
Received: from c122-106-145-25.carlnfd1.nsw.optusnet.com.au
	(c122-106-145-25.carlnfd1.nsw.optusnet.com.au [122.106.145.25])
	by mail09.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	o6FC4JTx022205
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 15 Jul 2010 22:04:21 +1000
Date: Thu, 15 Jul 2010 22:04:19 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@delplex.bde.org
To: Jung-uk Kim <jkim@freebsd.org>
In-Reply-To: <201007131657.o6DGvq9L097594@svn.freebsd.org>
Message-ID: <20100715220012.X1719@delplex.bde.org>
References: <201007131657.o6DGvq9L097594@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r210005 - head/sys/modules/acpi/acpi
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Jul 2010 12:04:23 -0000

On Tue, 13 Jul 2010, Jung-uk Kim wrote:

> Log:
>  Define SMP unconditionally for amd64 and remove opt_global.h from SRCS.
>  Note it is done just for correctness sake because we do not build, ship, or
>  support acpi.ko on amd64.
>
>  Prodded by:	bde

Thanks.

It was much more interesting than I noticed.  Modules are supposed to be
independent of all configuration options, especially global ones,
especially especially SMP.  Perhaps this is too much to ask for acpi.
Does it work now, after you removed an SMP ifdef from it?

Bruce