From owner-svn-src-all@freebsd.org Thu Nov 17 00:31:53 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 883A6C41550; Thu, 17 Nov 2016 00:31:53 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-qk0-x231.google.com (mail-qk0-x231.google.com [IPv6:2607:f8b0:400d:c09::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3D76B92; Thu, 17 Nov 2016 00:31:53 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-qk0-x231.google.com with SMTP id x190so198304901qkb.0; Wed, 16 Nov 2016 16:31:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=X7rMGVoS1o5k61m5yOIk2qEbVvmsG2bffAaMglNzquM=; b=QLViesshdfnFs0gwkKj34VbmVZC9KNxHn/00psEeRP2hucJB2Ew8aUlwnEBoFbFJUK Y42U6xydyQvz/RrITSdLr24wm1P4ABQAPhwlpwYeZ1IObP/cnjlbqHuj0eBLsYbMNemt JDxjbSs6I7DAy+sbTvFrFwv38qzV9vqGZNH6SwrcXkpFfJbOKaMyqAhBwIeBdj9+//Ts w5V5lh/G3GirE1ejef7SxqJa+ngIVytlY293RUExZHxfkNTlo/NkAg41Jkm2r1dt+yqw ic8ODltXAxyvh8Ww6gdrVhI8ZkRib6oAp/agETJJB81fP/tdmGrT5s34GkWzVmYxKfbq tvUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=X7rMGVoS1o5k61m5yOIk2qEbVvmsG2bffAaMglNzquM=; b=ff1DPal3rPsdAuv2KUmKEXEo46+HM9oJPCG3+XTZOWcNALFBC0MonrgzIkzCbmaCq6 PHEU2f2eHX/iX4IGWBjxFustcZesxwaAuGfxcQf8fS1q+naToYQMnufaV89117SkDxFe 7LiWx5Q4eJwSPxIFdV2XZoXlyca1LN9iLDIzUyG9pPIzFgx+t0Vo6sYS+ivXAgvvYyvr F5yFVMnG4iLa3Apo3nQY2HOC3IbhXLtJZcaOKUaI4dfg2lBhlmDn1ZamIXRsGK5V5Pn2 A8PyGkst0PX57/NfnRr0HlM6d3nWZ4UWRLIU0IpYvErYj4NlizxDV62q2qLvpqAm6/s3 yVzg== X-Gm-Message-State: AKaTC01IDriIIvgeiVhFa2JLc9kiA/R/u2ItmXavl7CvOfF6oAVQv5AlOzqRKW0bnwgxMhHS8Dp76n/3r7b83Q== X-Received: by 10.55.16.134 with SMTP id 6mr524234qkq.76.1479342712072; Wed, 16 Nov 2016 16:31:52 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.29.66 with HTTP; Wed, 16 Nov 2016 16:31:51 -0800 (PST) In-Reply-To: <20161116221440.GA83880@wkstn-mjohnston.west.isilon.com> References: <201611150236.uAF2aCV8015106@repo.freebsd.org> <20161116221440.GA83880@wkstn-mjohnston.west.isilon.com> From: Ngie Cooper Date: Wed, 16 Nov 2016 16:31:51 -0800 Message-ID: Subject: Re: svn commit: r308664 - in head: contrib/hyperv/tools etc/devd etc/mtree include share/man/man4 sys/conf sys/dev/hyperv/utilities sys/modules/hyperv/utilities usr.sbin/hyperv usr.sbin/hyperv/tools us... To: Mark Johnston Cc: Sepherosa Ziehau , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Nov 2016 00:31:53 -0000 On Wed, Nov 16, 2016 at 2:14 PM, Mark Johnston wrote: ... > This appears to install hv_kvp_daemon and hv_vss_daemon to / instead of > /usr/sbin, and breaks the -DNO_ROOT build. I think a Makefile.inc is > needed in usr.sbin/hyperv/tools in order to preserve BINDIR from > usr.sbin/Makefile.inc. I fixed the problem in my tree with the diff > below, but am not sure if this is the right way to do it. For some > reason, doing this resulted in unused var warnings compiling > hv_vss_daemon.c. The -Wunused warnings you're seeing are because you're now it's setting WARNS by .include'ing usr.bin/Makefile.inc ; it used to be set (I verified that), but then got unset between a few weeks ago and now on the directory: $ make -V.CURDIR -VWARNS /usr/src/usr.sbin/hyperv/tools $ Cheers, -Ngie PS -Wno-uninitialized is only set for gcc...? Really...???