Date: Fri, 28 Jul 2023 13:09:24 -0600 From: Warner Losh <imp@bsdimp.com> To: Jessica Clarke <jrtc27@jrtc27.com> Cc: Renato Botelho <garga@freebsd.org>, Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: 971bac5ace7a - main - kbd: consolidate kb interfaces (phase one) Message-ID: <CANCZdfoALMpPhhz89kU=5mV58Y70yQp66A6=0QaW%2BatfYHCyiw@mail.gmail.com> In-Reply-To: <40ECF84B-ECF1-4700-9059-F971BBD3668B@jrtc27.com> References: <202307070510.3675AWZS051152@gitrepo.freebsd.org> <65b0e348-b27d-f641-1004-6f76ff3ebfbd@FreeBSD.org> <CANCZdfoDXaO21ZfW6xvW%2BadyBWvHjs2FL_XGdG7uD23igwXKuA__2318.75493643514$1690513489$gmane$org@mail.gmail.com> <0504b648-df5e-4125-c4bc-01d4ecd5374d@FreeBSD.org> <40ECF84B-ECF1-4700-9059-F971BBD3668B@jrtc27.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000004e1cba060190d26a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jul 28, 2023, 1:04 PM Jessica Clarke <jrtc27@jrtc27.com> wrote: > On 28 Jul 2023, at 20:01, Renato Botelho <garga@FreeBSD.org> wrote: > > > > On 28/07/23 00:04, Warner Losh wrote: > >> On Thu, Jul 27, 2023 at 5:48=E2=80=AFAM Renato Botelho <garga@freebsd.= org > <mailto:garga@freebsd.org>> wrote: > >> On 07/07/23 02:10, Warner Losh wrote: > >> > The branch main has been updated by imp: > >> > > >> > URL: > >> > https://cgit.FreeBSD.org/src/commit/?id=3D971bac5ace7a3c2262349fa2808188a= 11a5ffeed > < > https://cgit.FreeBSD.org/src/commit/?id=3D971bac5ace7a3c2262349fa2808188a= 11a5ffeed > > > >> > > >> > commit 971bac5ace7a3c2262349fa2808188a11a5ffeed > >> > Author: Michael <git@paepcke.de <mailto:git@paepcke.de>> > >> > AuthorDate: 2023-07-07 02:32:45 +0000 > >> > Commit: Warner Losh <imp@FreeBSD.org> > >> > CommitDate: 2023-07-07 05:10:18 +0000 > >> > > >> > kbd: consolidate kb interfaces (phase one) > >> > > >> > Refactor to eliminate duplicated rate and delay tables, wit= h > >> minor style > >> > tweaks for changed lines. Remove an obsolete comment about > >> needing to > >> > convert from microseconds to ticks (that's done elsewhere). > >> Remove > >> > traiing whitespace in kbdcontrol.c. > >> > > >> > Except for the new warning, no change in behavior > >> > > >> > Sponsored by: DSS GmbH > >> > Reviewed by: imp [minor style tweaks as well] > >> > Pull Request: https://github.com/freebsd/pull/683 > >> <https://github.com/freebsd/pull/683>; > >> > Differential Revision: https://reviews.freebsd.org/D38818 > >> <https://reviews.freebsd.org/D38818>; > >> > --- > >> > sys/dev/adb/adb_kbd.c | 12 ++------- > >> > sys/dev/atkbdc/atkbd.c | 18 +++++--------- > >> > sys/dev/gpio/gpiokeys.c | 10 ++------ > >> > sys/dev/hid/hkbd.c | 10 ++------ > >> > sys/dev/kbdmux/kbdmux.c | 23 +++++------------ > >> > sys/dev/usb/input/ukbd.c | 10 ++------ > >> > sys/dev/vkbd/vkbd.c | 18 +++++--------- > >> > sys/sys/kbio.h | 7 ++++++ > >> > usr.sbin/kbdcontrol/kbdcontrol.c | 53 > >> +++++++++++++++++++++------------------- > >> > 9 files changed, 61 insertions(+), 100 deletions(-) > >> After this change I started seeing following error building > kbdcontrol: > >> Building > /usr/obj/usr/src/amd64.amd64/usr.sbin/kbdcontrol/kbdcontrol.o > >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:35: error: use of > >> undeclared identifier 'kbdelays'; did you mean 'ndelays'? > >> static const int ndelays =3D nitems(kbdelays); > >> ^~~~~~~~ > >> ndelays > >> /usr/include/sys/param.h:324:28: note: expanded from macro 'nitems' > >> #define nitems(x) (sizeof((x)) / sizeof((x)[0])) > >> ^ > >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:18: note: 'ndelays' > >> declared here > >> static const int ndelays =3D nitems(kbdelays); > >> ^ > >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:35: error: use of > >> undeclared identifier 'kbdelays'; did you mean 'ndelays'? > >> static const int ndelays =3D nitems(kbdelays); > >> ^~~~~~~~ > >> ndelays > >> /usr/include/sys/param.h:324:42: note: expanded from macro 'nitems' > >> #define nitems(x) (sizeof((x)) / sizeof((x)[0])) > >> ^ > >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:18: note: 'ndelays' > >> declared here > >> static const int ndelays =3D nitems(kbdelays); > >> ^ > >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:28: error: subscripted > >> value is not an array, pointer, or vector > >> static const int ndelays =3D nitems(kbdelays); > >> ^~~~~~~~~~~~~~~~ > >> /usr/include/sys/param.h:324:44: note: expanded from macro 'nitems' > >> #define nitems(x) (sizeof((x)) / sizeof((x)[0])) > >> ~~~^~ > >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:98:36: error: use of > >> undeclared identifier 'kbrates' > >> static const int nrepeats =3D nitems(kbrates); > >> ^ > >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:98:36: error: use of > >> undeclared identifier 'kbrates' > >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:1072:17: error: use of > >> undeclared identifier 'kbdelays'; did you mean 'ndelays'? > >> if (delay <=3D kbdelays[n]) > >> ^~~~~~~~ > >> ndelays > >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:18: note: 'ndelays' > >> declared here > >> static const int ndelays =3D nitems(kbdelays); > >> ^ > >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:1072:25: error: subscript= ed > >> value is not an array, pointer, or vector > >> if (delay <=3D kbdelays[n]) > >> ~~~~~~~~^~ > >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:1076:18: error: use of > >> undeclared identifier 'kbrates' > >> if (repeat <=3D kbrates[n]) > >> ^ > >> 8 errors generated. > >> *** Error code 1 > >> I haven't seen this. How do I recreate this? Does this happen on a > clean build? > > > > After I upgrade system to recent CURRENT the error is gone. > > kbdcontrol requires an updated sys/kbio.h, so if you try and do a make > of just it outside of make buildenv and without having first installed > updated headers to worldtmp then you won=E2=80=99t get the updated sys/kb= io.h. > I don=E2=80=99t think that=E2=80=99s something we support in general, onl= y when it > happens to work? > Generally you need to do a make buildenv and the rebuild inside of that environment. Warner > Jess > > --0000000000004e1cba060190d26a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" = class=3D"gmail_attr">On Fri, Jul 28, 2023, 1:04 PM Jessica Clarke <<a hr= ef=3D"mailto:jrtc27@jrtc27.com">jrtc27@jrtc27.com</a>> wrote:<br></div><= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">On 28 Jul 2023, at 20:01, Renato Botelho <= garga@FreeBSD.org> wrote:<br> > <br> > On 28/07/23 00:04, Warner Losh wrote:<br> >> On Thu, Jul 27, 2023 at 5:48=E2=80=AFAM Renato Botelho <<a href= =3D"mailto:garga@freebsd.org" target=3D"_blank" rel=3D"noreferrer">garga@fr= eebsd.org</a> <mailto:<a href=3D"mailto:garga@freebsd.org" target=3D"_bl= ank" rel=3D"noreferrer">garga@freebsd.org</a>>> wrote:<br> >>=C2=A0 =C2=A0 On 07/07/23 02:10, Warner Losh wrote:<br> >>=C2=A0 =C2=A0 =C2=A0> The branch main has been updated by imp:<b= r> >>=C2=A0 =C2=A0 =C2=A0><br> >>=C2=A0 =C2=A0 =C2=A0> URL:<br> >>=C2=A0 =C2=A0 <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3D= 971bac5ace7a3c2262349fa2808188a11a5ffeed" rel=3D"noreferrer noreferrer" tar= get=3D"_blank">https://cgit.FreeBSD.org/src/commit/?id=3D971bac5ace7a3c2262= 349fa2808188a11a5ffeed</a> <<a href=3D"https://cgit.FreeBSD.org/src/comm= it/?id=3D971bac5ace7a3c2262349fa2808188a11a5ffeed" rel=3D"noreferrer norefe= rrer" target=3D"_blank">https://cgit.FreeBSD.org/src/commit/?id=3D971bac5ac= e7a3c2262349fa2808188a11a5ffeed</a>><br> >>=C2=A0 =C2=A0 =C2=A0><br> >>=C2=A0 =C2=A0 =C2=A0> commit 971bac5ace7a3c2262349fa2808188a11a5= ffeed<br> >>=C2=A0 =C2=A0 =C2=A0> Author:=C2=A0 =C2=A0 =C2=A0Michael <<a = href=3D"mailto:git@paepcke.de" target=3D"_blank" rel=3D"noreferrer">git@pae= pcke.de</a> <mailto:<a href=3D"mailto:git@paepcke.de" target=3D"_blank" = rel=3D"noreferrer">git@paepcke.de</a>>><br> >>=C2=A0 =C2=A0 =C2=A0> AuthorDate: 2023-07-07 02:32:45 +0000<br> >>=C2=A0 =C2=A0 =C2=A0> Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <= ;imp@FreeBSD.org><br> >>=C2=A0 =C2=A0 =C2=A0> CommitDate: 2023-07-07 05:10:18 +0000<br> >>=C2=A0 =C2=A0 =C2=A0><br> >>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 kbd: consolidate kb in= terfaces (phase one)<br> >>=C2=A0 =C2=A0 =C2=A0><br> >>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 Refactor to eliminate = duplicated rate and delay tables, with<br> >>=C2=A0 =C2=A0 minor style<br> >>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 tweaks for changed lin= es.=C2=A0 Remove an obsolete comment about<br> >>=C2=A0 =C2=A0 needing to<br> >>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 convert from microseco= nds to ticks (that's done elsewhere).<br> >>=C2=A0 =C2=A0 Remove<br> >>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 traiing whitespace in = kbdcontrol.c.<br> >>=C2=A0 =C2=A0 =C2=A0><br> >>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 Except for the new war= ning, no change in behavior<br> >>=C2=A0 =C2=A0 =C2=A0><br> >>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 Sponsored by:=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0DSS GmbH<br> >>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 Reviewed by:=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 imp [minor style tweaks as well]<br> >>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 Pull Request: <a href= =3D"https://github.com/freebsd/pull/683" rel=3D"noreferrer noreferrer" targ= et=3D"_blank">https://github.com/freebsd/pull/683</a><br>; >>=C2=A0 =C2=A0 <<a href=3D"https://github.com/freebsd/pull/683" r= el=3D"noreferrer noreferrer" target=3D"_blank">https://github.com/freebsd/p= ull/683</a>><br> >>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 Differential Revision:= <a href=3D"https://reviews.freebsd.org/D38818" rel=3D"noreferrer noreferre= r" target=3D"_blank">https://reviews.freebsd.org/D38818</a><br>; >>=C2=A0 =C2=A0 <<a href=3D"https://reviews.freebsd.org/D38818" re= l=3D"noreferrer noreferrer" target=3D"_blank">https://reviews.freebsd.org/D= 38818</a>><br> >>=C2=A0 =C2=A0 =C2=A0> ---<br> >>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0sys/dev/adb/adb_kbd.c=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 12 ++-------<br> >>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0sys/dev/atkbdc/atkbd.c=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 18 +++++---------<br> >>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0sys/dev/gpio/gpiokeys.c=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 10 ++------<br> >>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0sys/dev/hid/hkbd.c=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 10 ++------<br> >>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0sys/dev/kbdmux/kbdmux.c=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 23 +++++------------<br> >>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0sys/dev/usb/input/ukbd.c=C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0| 10 ++------<br> >>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0sys/dev/vkbd/vkbd.c=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 18 +++++---------<br> >>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0sys/sys/kbio.h=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 7 ++++++<br> >>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0usr.sbin/kbdcontrol/kbdcontrol= .c | 53<br> >>=C2=A0 =C2=A0 +++++++++++++++++++++-------------------<br> >>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A09 files changed, 61 insertions= (+), 100 deletions(-)<br> >>=C2=A0 =C2=A0 After this change I started seeing following error bu= ilding kbdcontrol:<br> >>=C2=A0 =C2=A0 Building /usr/obj/usr/src/amd64.amd64/usr.sbin/kbdcon= trol/kbdcontrol.o<br> >>=C2=A0 =C2=A0 /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:35: erro= r: use of<br> >>=C2=A0 =C2=A0 undeclared identifier 'kbdelays'; did you mea= n 'ndelays'?<br> >>=C2=A0 =C2=A0 static const int ndelays =3D nitems(kbdelays);<br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^= ~~~~~~~<br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 n= delays<br> >>=C2=A0 =C2=A0 /usr/include/sys/param.h:324:28: note: expanded from = macro 'nitems'<br> >>=C2=A0 =C2=A0 #define nitems(x)=C2=A0 =C2=A0 =C2=A0 =C2=A0(sizeof((= x)) / sizeof((x)[0]))<br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^<= br> >>=C2=A0 =C2=A0 /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:18: note= : 'ndelays'<br> >>=C2=A0 =C2=A0 declared here<br> >>=C2=A0 =C2=A0 static const int ndelays =3D nitems(kbdelays);<br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0^<br> >>=C2=A0 =C2=A0 /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:35: erro= r: use of<br> >>=C2=A0 =C2=A0 undeclared identifier 'kbdelays'; did you mea= n 'ndelays'?<br> >>=C2=A0 =C2=A0 static const int ndelays =3D nitems(kbdelays);<br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^= ~~~~~~~<br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 n= delays<br> >>=C2=A0 =C2=A0 /usr/include/sys/param.h:324:42: note: expanded from = macro 'nitems'<br> >>=C2=A0 =C2=A0 #define nitems(x)=C2=A0 =C2=A0 =C2=A0 =C2=A0(sizeof((= x)) / sizeof((x)[0]))<br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^<br> >>=C2=A0 =C2=A0 /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:18: note= : 'ndelays'<br> >>=C2=A0 =C2=A0 declared here<br> >>=C2=A0 =C2=A0 static const int ndelays =3D nitems(kbdelays);<br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0^<br> >>=C2=A0 =C2=A0 /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:28: erro= r: subscripted<br> >>=C2=A0 =C2=A0 value is not an array, pointer, or vector<br> >>=C2=A0 =C2=A0 static const int ndelays =3D nitems(kbdelays);<br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^~~~~~~~~~~~~~~~<br> >>=C2=A0 =C2=A0 /usr/include/sys/param.h:324:44: note: expanded from = macro 'nitems'<br> >>=C2=A0 =C2=A0 #define nitems(x)=C2=A0 =C2=A0 =C2=A0 =C2=A0(sizeof((= x)) / sizeof((x)[0]))<br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ~~~^~<br> >>=C2=A0 =C2=A0 /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:98:36: erro= r: use of<br> >>=C2=A0 =C2=A0 undeclared identifier 'kbrates'<br> >>=C2=A0 =C2=A0 static const int nrepeats =3D nitems(kbrates);<br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0^<br> >>=C2=A0 =C2=A0 /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:98:36: erro= r: use of<br> >>=C2=A0 =C2=A0 undeclared identifier 'kbrates'<br> >>=C2=A0 =C2=A0 /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:1072:17: er= ror: use of<br> >>=C2=A0 =C2=A0 undeclared identifier 'kbdelays'; did you mea= n 'ndelays'?<br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (delay <=3D kbdelays[n])<br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0^~~~~~~~<br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0ndelays<br> >>=C2=A0 =C2=A0 /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:18: note= : 'ndelays'<br> >>=C2=A0 =C2=A0 declared here<br> >>=C2=A0 =C2=A0 static const int ndelays =3D nitems(kbdelays);<br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0^<br> >>=C2=A0 =C2=A0 /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:1072:25: er= ror: subscripted<br> >>=C2=A0 =C2=A0 value is not an array, pointer, or vector<br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (delay <=3D kbdelays[n])<br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0~~~~~~~~^~<br> >>=C2=A0 =C2=A0 /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:1076:18: er= ror: use of<br> >>=C2=A0 =C2=A0 undeclared identifier 'kbrates'<br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (repeat <=3D kbrates[n])<br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 ^<br> >>=C2=A0 =C2=A0 8 errors generated.<br> >>=C2=A0 =C2=A0 *** Error code 1<br> >> I haven't seen this. How do I recreate this? Does this happen = on a clean build?<br> > <br> > After I upgrade system to recent CURRENT the error is gone.<br> <br> kbdcontrol requires an updated sys/kbio.h, so if you try and do a make<br> of just it outside of make buildenv and without having first installed<br> updated headers to worldtmp then you won=E2=80=99t get the updated sys/kbio= .h.<br> I don=E2=80=99t think that=E2=80=99s something we support in general, only = when it<br> happens to work?<br></blockquote></div></div><div dir=3D"auto"><br></div><d= iv dir=3D"auto">Generally you need to do a make buildenv and the rebuild in= side of that environment.=C2=A0</div><div dir=3D"auto"><br></div><div dir= =3D"auto">Warner=C2=A0</div><div dir=3D"auto"><div class=3D"gmail_quote"><b= lockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px = #ccc solid;padding-left:1ex"> Jess<br> <br> </blockquote></div></div></div> --0000000000004e1cba060190d26a--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoALMpPhhz89kU=5mV58Y70yQp66A6=0QaW%2BatfYHCyiw>