Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 1 Apr 2013 09:39:36 GMT
From:      Fredrik Nyström <fredrik@lysator.liu.se>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/177540: x11/gnome2: Typo in Makefile: OPTIONS_DEFINE= XSCHEENSAVER
Message-ID:  <201304010939.r319daSd022579@red.freebsd.org>
Resent-Message-ID: <201304010940.r319e1pc016654@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         177540
>Category:       ports
>Synopsis:       x11/gnome2: Typo in Makefile: OPTIONS_DEFINE= XSCHEENSAVER
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 01 09:40:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Fredrik Nyström
>Release:        9.1-RELEASE
>Organization:
>Environment:
FreeBSD rorworr 9.1-RELEASE FreeBSD 9.1-RELEASE #0 r246872: Sat Feb 16 15:14:28 CET 2013     root@rorworr:/usr/obj/usr/src/sys/RORWORR  amd64
>Description:
To successfully build both x11/gnome2 and x11/kde4 you will need the following options:
x11/gnome2: OPTIONS_FILE_SET+=XSCREENSAVER
x11-themes/kdeartwork4: OPTIONS_FILE_SET+=GNOME

If you use make config in /usr/ports/x11/gnome2, "[x] XSCHEENSAVER" has no effect since it's mistyped in Makefile. You will still get x11/gnome-screensaver instead of x11/xscreensaver-gnome.

Not related to this bug but I think it would be nice if the gnome and kde teams could agree on a screensaver solution that does not require non default options to build both x11/gnome2 and x11/kde4.

Regards / Fredrik
>How-To-Repeat:

>Fix:
--- x11/gnome2/Makefile (revision 315646)
+++ x11/gnome2/Makefile (working copy)
@@ -63,7 +63,7 @@
 .endif
 
 .if !defined(GNOME_SLAVE) || ${.CURDIR:T}=="gnome2-lite"
-OPTIONS_DEFINE=        XSCHEENSAVER
+OPTIONS_DEFINE=        XSCREENSAVER
 XSCREENSAVER_DESC=     Use xscreensaver as screen saver app
 #              MAPI "Depend on evolution-mapi (pulls in samba4)
 .endif


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201304010939.r319daSd022579>