Date: Thu, 29 Nov 2012 19:35:11 +0000 From: Chris Rees <crees@FreeBSD.org> To: Baptiste Daroussin <bapt@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r306707 - in head/net-mgmt: . netmagis-common netmagis-common/files Message-ID: <CADLo83_TFGJvOpS9rC4w5fBqO=Kebckim7vBiZviJ1tur2hd0w@mail.gmail.com> In-Reply-To: <20121129184830.GB31288@ithaqua.etoilebsd.net> References: <201210302027.q9UKRAdf068736@svn.freebsd.org> <20121129184830.GB31288@ithaqua.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 29 November 2012 18:48, Baptiste Daroussin <bapt@freebsd.org> wrote: > On Tue, Oct 30, 2012 at 08:27:10PM +0000, Chris Rees wrote: >> Author: crees >> Date: Tue Oct 30 20:27:10 2012 >> New Revision: 306707 >> URL: http://svn.freebsd.org/changeset/ports/306707 >> > > [...] >> + ${LOCALBASE}/libexec/apache22/mod_auth_pgsql.so:${PORTSDIR}/www/mod_auth_pgsql2/ > the '/' in the end is bad, a lot of tools rely on make -VRUN_DEPENDS and > not on make run-depends-list just because it is faster (in one run you can get > multiple -V) and they will end up with a ${PORTSDIR}/www/mod_auth_pgsql2/ > depend instead of ${PORTSDIR}/www/mod_auth_pgsql2 while this case is pretty easy > to fix in those tools, I just want to point here that it is really important to > respect the classic synopsis for dependencies: > > ${PORTSDIR}/category/portname > > without an ending '/' or without ${.CURDIR}/../ or anything like that. Pointed out, noted and corrected. Thank you, and I'm sorry :) Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo83_TFGJvOpS9rC4w5fBqO=Kebckim7vBiZviJ1tur2hd0w>