From owner-freebsd-ports-bugs@freebsd.org Fri Jul 8 08:56:37 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A626DB80A73 for ; Fri, 8 Jul 2016 08:56:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 956E51D62 for ; Fri, 8 Jul 2016 08:56:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u688ubck060652 for ; Fri, 8 Jul 2016 08:56:37 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 210876] multimedia/assimp: Update to 3.3 Date: Fri, 08 Jul 2016 08:56:37 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: easy, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: lightside@gmx.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jul 2016 08:56:37 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210876 --- Comment #9 from lightside --- (In reply to comment #8) > Ok, you need to create patches with 'svn diff', they always apply easy. I used sources from portsnap and created patch with `diff -ruN assimp.orig assimp > assimp.diff`, the command of which also mentioned in attachment #172218. I wrote how to apply such kind of patch(es) in comment #6 and there were no problems in other PRs with this. (In reply to comment #8) > Let's put this on hold in the hope that they will re-release it. Agreed, based on description in current v3.3 tag: https://github.com/assimp/assimp/commit/19769eef8b9612a82fdb55c245db871476e= 7f178 "Version: prepare 3.3 version.", they (still) prepare it. There are no description of changes for 3.3 version in current commit: https://github.com/assimp/assimp/blob/19769eef8b9612a82fdb55c245db871476e7f= 178/CHANGES You commented on https://github.com/assimp/assimp/issues/940 > pstdint.h isn't of the latest version. You have 0.1.12 and the current > version is 0.1.15.4. The FreeBSD port for some reason patches it to 0.1.1= 5.4. > I am not sure why, somebody needed the latest version. But why don't you = just > update it in here, upstream? The reasons are: - The 3.2 version in bug 209356 required newer pstdint.h file to fix build = on FreeBSD 10.x. - Between 3.2 and 3.3 versions the pstdint.h was custom patched in https://github.com/assimp/assimp/issues/795 to 0.1.12 version. It gives following warnings on FreeBSD 10.2, for example: -8<-- In file included from /usr/ports/multimedia/assimp/work/assimp-19769ee/contrib/irrXML/irrXML.cpp:= 12: In file included from /usr/ports/multimedia/assimp/work/assimp-19769ee/contrib/irrXML/./../../cod= e/fast_atof.h:29: /usr/ports/multimedia/assimp/work/assimp-19769ee/include/assimp/Compiler/ps= tdint.h:678:10: warning: 'UINT_FAST64_MAX' macro redefined # define UINT_FAST64_MAX UINT_LEAST64_MAX ^ /usr/include/x86/_stdint.h:136:9: note: previous definition is here #define UINT_FAST64_MAX UINT64_MAX ^ In file included from /usr/ports/multimedia/assimp/work/assimp-19769ee/contrib/irrXML/irrXML.cpp:= 12: In file included from /usr/ports/multimedia/assimp/work/assimp-19769ee/contrib/irrXML/./../../cod= e/fast_atof.h:29: /usr/ports/multimedia/assimp/work/assimp-19769ee/include/assimp/Compiler/ps= tdint.h:674:10: warning: 'INT_FAST32_MIN' macro redefined #define INT_FAST32_MIN INT_LEAST32_MIN ^ /usr/include/x86/_stdint.h:123:9: note: previous definition is here #define INT_FAST32_MIN INT32_MIN ^ In file included from /usr/ports/multimedia/assimp/work/assimp-19769ee/tools/assimp_cmd/ImageExtr= actor.cpp:47: In file included from /usr/ports/multimedia/assimp/work/assimp-19769ee/include/../code/fast_atof.= h:29: /usr/ports/multimedia/assimp/work/assimp-19769ee/include/assimp/Compiler/ps= tdint.h:320:12: warning: 'INT8_C' macro redefined # define INT8_C(v) ((int8_t) v) ^ /usr/include/x86/_stdint.h:45:9: note: previous definition is here #define INT8_C(c) (c) ^ etc. -->8- Therefore, it's advisable to patch it for 3.3 version also. I think, you ne= ed to point upstream to official source of pstdint.h file, if you want to reso= lve this on upstream level: http://www.azillionmonkeys.com/qed/pstdint.h --=20 You are receiving this mail because: You are the assignee for the bug.=