From owner-svn-src-head@freebsd.org Thu Dec 6 19:08:53 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 98ABA130F906; Thu, 6 Dec 2018 19:08:53 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-it1-x141.google.com (mail-it1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EA91A7B37B; Thu, 6 Dec 2018 19:08:52 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by mail-it1-x141.google.com with SMTP id p197so3262304itp.0; Thu, 06 Dec 2018 11:08:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BfBPbcUNYyH/rAtxBLtWh/5/QCL/4/KWg3FlQMfNZAU=; b=iR8YynyT3ax8YEUWuOs/6/troaT+HIKIkqHKKj4lM+/LbvPbJ2mKMBKiIVy81U6BBM staO8hwrtYRcvHY2AQTw9FlpmUXsrkIGmmFoPNuaPOsbAmaQlMp+St+w6zZdfP1zS9eP Hs5tVXB4yx2FQntCy0PH/3ylp+rhwqLz2YCLOdP1yEDNrrfk+Kg6Kcgv3f/vujYti/Er pkpCcTVbg4uqhr4Y05IjVGDKcqas4xQE/tLXncKLZF9g/hpvpQA6L5rLoHwBNkNfewoY 95HlK4WN0NZIq8Rm0z/AMjY1ql8/dhUADu5J/EJrd/VFZRB19+oG+FSTCYqswUNwYdPn zY5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=BfBPbcUNYyH/rAtxBLtWh/5/QCL/4/KWg3FlQMfNZAU=; b=CKzwq5jDXb2D9F4iKQqzjSL4JpuW98wD34lpFanMrkeQ5LSiZAQjZGUNTqci9hQFzP tktql2evUr1+94KZEh9+NVphnc1tgmI9UkL4xsnce31QtXrNhs7XgiSbfbtTF45wYHL8 rzVzaifFZjJ4OAdjtBk4b2PI2w4eaiIeEMkZ7M4kABrg4k1LcDo0F5SU2kjo2p5fr/Rx 0pfijwd57gv8NmmuM/ItDh91+lXeESKhIDOYOZgQRRYC+0eVBiGVKyOJayPTeNWhnSef pFb9ziyDWGMfFWiWIJN8FtuYLfRRYVKsIo7utJ0YK3vkz/LfVktWsTrgE9igFLfA7EBE D4PQ== X-Gm-Message-State: AA+aEWb6+cBJ6EdUYSCCejgsWLahZbiFd1p0xfMdeESLfkLOi5u0FoC4 vhEsfqydUYvGayIZy1UT+5C63fCE150= X-Google-Smtp-Source: AFSGD/Wt/yPUiZWgjPb34XUqs9otnlyI6EUzOcwqYdMbajYj1prQO9aVTSSbGDvDrgUnyAIPG9iWiw== X-Received: by 2002:a02:c891:: with SMTP id m17mr26793081jao.45.1544123331877; Thu, 06 Dec 2018 11:08:51 -0800 (PST) Received: from ralga.knownspace (173-25-245-129.client.mchsi.com. [173.25.245.129]) by smtp.gmail.com with ESMTPSA id r16sm463174ioa.16.2018.12.06.11.08.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 06 Dec 2018 11:08:51 -0800 (PST) Sender: Justin Hibbits Date: Thu, 6 Dec 2018 13:08:45 -0600 From: Justin Hibbits To: Mark Johnston Cc: Kyle Evans , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org, Li-Wen Hsu Subject: Re: svn commit: r339516 - head/sys/cddl/dev/dtrace/powerpc Message-ID: <20181206130845.6088ea55@ralga.knownspace> In-Reply-To: <20181122071629.GA96830@raichu> References: <201810210208.w9L28vVc080088@repo.freebsd.org> <20181122071629.GA96830@raichu> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; powerpc64-portbld-freebsd13.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: EA91A7B37B X-Spamd-Result: default: False [-1.45 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com]; NEURAL_HAM_MEDIUM(-0.69)[-0.686,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_LONG(-0.86)[-0.858,0]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(0.18)[ip: (3.80), ipnet: 2607:f8b0::/32(-1.53), asn: 15169(-1.31), country: US(-0.09)]; NEURAL_SPAM_SHORT(0.13)[0.128,0]; DKIM_TRACE(0.00)[gmail.com:+]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[1.4.1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; FORGED_SENDER(0.30)[jhibbits@FreeBSD.org,chmeeedalf@gmail.com]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[jhibbits@FreeBSD.org,chmeeedalf@gmail.com] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Dec 2018 19:08:53 -0000 On Thu, 22 Nov 2018 02:16:29 -0500 Mark Johnston wrote: > On Wed, Nov 21, 2018 at 10:02:15PM -0600, Kyle Evans wrote: > > On Wed, Nov 21, 2018 at 9:42 PM Kyle Evans > > wrote: > > > > > > On Sat, Oct 20, 2018 at 9:09 PM Justin Hibbits > > > wrote: > > > > > > > > Author: jhibbits > > > > Date: Sun Oct 21 02:08:57 2018 > > > > New Revision: 339516 > > > > URL: https://svnweb.freebsd.org/changeset/base/339516 > > > > > > > > Log: > > > > powerpc/dtrace: Use explicit bit numbers to mask out PSL_EE > > > > > > > > There seems to be a race in CI, such that dtrace_asm.S might > > > > be assembled before the genassym is completed. This causes a > > > > build failure when PSL_EE doesn't exist, and is read as 0. Get > > > > around this by explicitly specifying the bits in the mask > > > > instead. > > > > > > Hi, > > > > > > CI on the stable/12 branch still hits this, so I'm tempted to MFC > > > this if you don't object. OTOH, the correct solution should be a > > > `dependency "genassym.o"` in ^/sys/conf/files.powerpc for > > > dtrace_asm.S, no? > > I believe that dtrace_asm.S will be built as part of dtrace.ko, not > the kernel. dtrace/Makefile already specifies a dependency on > assym.inc. Maybe this is the same issue as PR 233339? > > > Sorry, that should have read "genassym.inc" -- my naive > > understanding of 'dependency' is that config(8) will turn it > > directly into a makefile dependency that will alleviate this. > > Yep, looks a lot like PR 233339. - Justin