From owner-cvs-all Wed Apr 10 23:17:43 2002 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 65E5037B400; Wed, 10 Apr 2002 23:17:35 -0700 (PDT) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id QAA28592; Thu, 11 Apr 2002 16:17:05 +1000 Date: Thu, 11 Apr 2002 16:16:49 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: "David O'Brien" Cc: cvs-committers@FreeBSD.org, Subject: Re: cvs commit: src/share/mk bsd.sys.mk In-Reply-To: <20020410180036.B84993@dragon.nuxi.com> Message-ID: <20020411160322.B3429-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 10 Apr 2002, David O'Brien wrote: > On Wed, Apr 10, 2002 at 06:26:00PM +1000, Bruce Evans wrote: > > This gives me more to check before deciding if removing it easy enough :-). > > I think modifying the sources files to not produce syntax errors for > > foreign macros should be acceptable in most cases, since files in contrib > > should be portable so they can't depend on OS-dependent macros, > > Unfortunately when we take them from NetBSD they do. lukemftp and lukemftpd are counterexamples. I think most sources in contrib should be like this. > > and files > > outside of contrib get modified anyway. > > You did not respond to creating the non-standard /usr/include/scm.h as a > place to put all these various compatibility macros. I like it better than for FreeBSD ids, but think it would just increase unportability. You would still have to edit files to add it, and it is not so easy to kill using Makefile hacks like -D__RCSID=__IGNORE where __IGNORE() expands to nothing. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message