From owner-freebsd-current@freebsd.org Tue Mar 2 18:32:16 2021 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B503354B6F3 for ; Tue, 2 Mar 2021 18:32:16 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dqm274j5mz4rnX; Tue, 2 Mar 2021 18:32:15 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 122IW9D9047926; Tue, 2 Mar 2021 10:32:09 -0800 (PST) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: (from freebsd-rwg@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 122IW831047925; Tue, 2 Mar 2021 10:32:08 -0800 (PST) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <202103021832.122IW831047925@gndrsh.dnsmgr.net> Subject: Re: testers needed: loader: use display pixel density for font autoselection In-Reply-To: To: Toomas Soome Date: Tue, 2 Mar 2021 10:32:08 -0800 (PST) CC: "Rodney W. Grimes" , rgrimes@freebsd.org, Jakob Alvermark , FreeBSD Developers , freebsd-current X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4Dqm274j5mz4rnX X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of freebsd-rwg@gndrsh.dnsmgr.net has no SPF policy when checking 69.59.192.140) smtp.mailfrom=freebsd-rwg@gndrsh.dnsmgr.net X-Spamd-Result: default: False [-2.10 / 15.00]; RCVD_TLS_LAST(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[dnsmgr.net]; RBL_DBL_DONT_QUERY_IPS(0.00)[69.59.192.140:from]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[6]; SPAMHAUS_ZRD(0.00)[69.59.192.140:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-1.00)[-1.000]; R_SPF_NA(0.00)[no SPF record]; FREEMAIL_TO(0.00)[me.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[freebsd-current] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Mar 2021 18:32:16 -0000 > > On 26. Feb 2021, at 17:56, Rodney W. Grimes wrote: > > > >>> On 26. Feb 2021, at 05:42, Rodney W. Grimes wrote: > >>> > >>>>> On 23. Feb 2021, at 17:53, Jakob Alvermark wrote: > >>>>> > >>>>> On 2/23/21 12:27 PM, Toomas Soome via freebsd-current wrote: > >>>>>> hi! > >>>>>> > >>>>>> I have done some work to make font pickup a bit smarter (hopefully better;), but my own ability to test is limited to one bugged supermicro and one MBP with retina display? > >>>>>> > >>>>>> The phab link ishttps://reviews.freebsd.org/D28849 > >>>>>> > >>>>>> I have built loader binaries as well (bios and uefi): > >>>>>> loader_lua > >>>>>> loader_lua.efi I have tested this on: Lenovo W530 Dell E5470 Acer Aspire 1410 all work fine with resonable display resolution. One more comment below... > >>>>>> > >>>>>> To test, you should remove screen.font= line from loader.conf and test with different resolutions. > >>>>>> > >>>>>> thanks, > >>>>>> toomas > >>>>> > >>>>> > >>>>> > >>>>> Hi Toomas, > >>>>> > >>>>> > >>>>> I tested on five different setups. > >>>>> > >>>>> Surface Pro 10.6"@1920x1080: > >>>>> > >>>>> The loader menu looks different, the "FreeBSD" text is on the right side of the screen. > >>>> > >>>> > >>>> I think, this was the lua script bug we did fix not too long time ago. > >>>> > >>>>> > >>>>> Otherwise, the font size is what I would call a normal size. > >>>>> > >>>>> > >>>>> Acer laptop 11.6"@1366x768: > >>>>> > >>>>> Menu looks fine. Almost fills the entire screen. > >>>>> > >>>>> The font feels a little too big. > >>>> > >>>> > >>>> The laptop built in displays usually do not give out EDID (we get physical dimensions from EDID), so there we fall back to try to get 80x25 terminal method. > >>> > >>> I am having a hard time with that statement. EDID is very common on laptop screens, infact I can not recall ever not seeing EDID on a laptops builtin screen. > >>> My 11" acer 1400 has EDID in it. > >>> > >>> > >> > >> > >> If there is EDID, then it is all good. I have seen cases we do not get it with available API. > > > > Is there a way for me to know if the laoder found EDID data or not? > > It might be that the issue is that what ever loader is using for an API is not working. > > I based my "EDID is very common on laptop screens" on the fact that X11 almost always finds EDID. > > > > Yes, gop get / vbe list ? yes, it is inconsistent, should fix at some point? :) > > we do use gop get active edid/get discovered edid protocol and vbe function 0x4f15. On all my handy laptops, E5470, T400, W530, Acer 1410 edid is present and seen by the loader. > > rgds, > toomas -- Rod Grimes rgrimes@freebsd.org