From owner-svn-src-all@freebsd.org Thu Aug 6 02:22:50 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AE11F9B2D06; Thu, 6 Aug 2015 02:22:50 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 9879680E; Thu, 6 Aug 2015 02:22:50 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from FreeBSD.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by freefall.freebsd.org (Postfix) with ESMTP id 8FE301FE9; Thu, 6 Aug 2015 02:22:49 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Date: Thu, 6 Aug 2015 02:22:47 +0000 From: Glen Barber To: Pawel Jakub Dawidek Cc: Andriy Gapon , "K. Macy" , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" , Xin Li Subject: Re: svn commit: r285021 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <20150806022247.GG1484@FreeBSD.org> References: <201507020832.t628W3WJ002944@repo.freebsd.org> <55BF6A84.1040808@FreeBSD.org> <20150806021723.GB72832@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FKNvYlRPwIaB7a7A" Content-Disposition: inline In-Reply-To: <20150806021723.GB72832@garage.freebsd.pl> X-Operating-System: FreeBSD 11.0-CURRENT amd64 X-SCUD-Definition: Sudden Completely Unexpected Dataloss X-SULE-Definition: Sudden Unexpected Learning Event X-PEKBAC-Definition: Problem Exists, Keyboard Between Admin/Computer User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Aug 2015 02:22:50 -0000 --FKNvYlRPwIaB7a7A Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 06, 2015 at 04:17:23AM +0200, Pawel Jakub Dawidek wrote: > On Mon, Aug 03, 2015 at 04:20:04PM +0300, Andriy Gapon wrote: > > On 30/07/2015 10:24, K. Macy wrote: > > > Just FYI this change introduces a deadlock with with the > > > spa_namespace_lock. Mount will be holding this lock while trying to > > > acquire the spa_namespace_lock. zfskern on the other hand holds the > > > spa_namespace_lock when calling zfs_freebsd_access which in turn > > > tries to acquire the teardown lock. > >=20 > > I missed the fact that zpool.cache file is being written with spa_names= pace_lock > > held. > > I'll try to either resolve the problem in the next day or I will revert= the change. >=20 > FYI, I'm hitting this deadlock on my laptop. Reverting the change fixes > the problem. >=20 Since it is now 3 days after "I'll try to either resolve the problem in the next day or I will revert the change", my view is that this needs to be reverted now, if it hasn't been done already. Glen --FKNvYlRPwIaB7a7A Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVwsT3AAoJEAMUWKVHj+KTdzIP/0vZvt3OJer0VSmabwe8NPM8 UNmfH26O64kv9s0Vjk2sZhKQhI0fNK4caaI2WQrW7P/pyOuW9/G9VUzCMrHNm3hV p7hSFEhaBj4iFaS8rWqpwaV3twOH6IeGiLuwMx2E1JnGVnU09TSzotNTki4JkDmx BHTenhzvGPYX+FRDZL2hwoTkh/Y581rd8MKLeNNXHiiMi57yLFgurola3DJJ7l8q cefyK1HcP10mkySl4BfDF4tfSF74p5xrvslRohq+eu7OsEugljajOiGN4SRQB2l8 HMkjZrR+85b2QY3Neih/1pfFzKnVcoSbnSChtY3WLRxZUbRFBZEkAqjMDPHU4ED/ jDe76RYxaC5ChkKYdfUu5Xa2f1xCLoZ32TgK6UvUv8hIK+qn2ghwILWaCOTiO4aM Rit01BTRlogwJzhWJCI1SRbP6LlWG//dWDbHyupYeCGRnm8/5+Xub2RyLxD8ILv3 FpniER7tDoMUrABG+lMIJuDE3+E5UHX37tDcwQDr0zETJNXbXuRQFjm+fJDtM+uh ygYtriwN3RJNRo3zVyrEBITDpBBUXBlgHHg8v9OmlIcMiJqLzE0SoAFsT645sGxS kqnuy72gCQVtNKxsbbrcD43P/GlgFLpbY1SndR8v9b53m1V7HbimNbQ2rB5atoiZ ulf1WduAHHsPmEf8nV+b =DB+n -----END PGP SIGNATURE----- --FKNvYlRPwIaB7a7A--