From owner-svn-ports-all@freebsd.org Mon Jan 6 22:46:57 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C55FC1F8C02; Mon, 6 Jan 2020 22:46:57 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47s9cK4m1pz4M5L; Mon, 6 Jan 2020 22:46:57 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from mail.j.mat.cc (owncloud.cube.mat.cc [IPv6:2a01:678:4:1::228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.mat.cc", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 8274E18B88; Mon, 6 Jan 2020 22:46:57 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from atuin.in.mat.cc (unknown [IPv6:2a01:678:42:ffff:80b0:dd5:9194:125a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id 4C63F942D81; Mon, 6 Jan 2020 22:46:56 +0000 (UTC) Date: Mon, 6 Jan 2020 23:46:56 +0100 From: Mathieu Arnold To: Adam Weinberger Cc: Larry Rosenman , Cy Schubert , ports-committers , svn-ports-all , svn-ports-head Subject: Re: svn commit: r522273 - in head/sysutils/lsof: . files Message-ID: <20200106224656.wefyervptxppm4pv@atuin.in.mat.cc> References: <202001062042.006Kg81F048249@repo.freebsd.org> <202001062102.006L2KrM089339@slippy.cwsent.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ragng7dcmjr4gi3y" Content-Disposition: inline In-Reply-To: X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jan 2020 22:46:57 -0000 --ragng7dcmjr4gi3y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 06, 2020 at 02:19:58PM -0700, Adam Weinberger wrote: > On Mon, Jan 6, 2020 at 2:05 PM Larry Rosenman wrote: > > > > On 01/06/2020 3:02 pm, Cy Schubert wrote: > > > In message <202001062042.006Kg81F048249@repo.freebsd.org>, Larry > > > Rosenman > > > write > > > s: > > >> Author: ler > > >> Date: Mon Jan 6 20:42:08 2020 > > >> New Revision: 522273 > > >> URL: https://svnweb.freebsd.org/changeset/ports/522273 > > >> > > >> Log: > > >> sysutils/lsof: fix build following base r356337. > > >> > > >> I took the patch from 243122 as it was more correct. > > >> > > >> PR: 243122, 243083 > > >> Submitted by: cy, yasu@utahime.org > > >> > > >> Added: > > >> head/sysutils/lsof/files/patch-dialects_freebsd_dnode2.c > > >> (contents, props > > >> changed) > > >> Modified: > > >> head/sysutils/lsof/Makefile > > >> > > >> Modified: head/sysutils/lsof/Makefile > > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > >> =3D > > >> --- head/sysutils/lsof/Makefile Mon Jan 6 20:25:36 2020 = (r52227 > > >> 2) > > >> +++ head/sysutils/lsof/Makefile Mon Jan 6 20:42:08 2020 = (r52227 > > >> 3) > > >> @@ -3,7 +3,7 @@ > > >> > > >> PORTNAME=3D lsof > > >> DISTVERSION=3D 4.93.2 > > >> -PORTREVISION=3D 6 > > >> +PORTREVISION=3D 8 > > > > > > Was this needed? The package doesn't change, only fixing the build. > > > > > >> PORTEPOCH=3D 8 > > >> CATEGORIES=3D sysutils > > >> > > >> > > > > I thought build breaks on the cluster needed a port rev bump... >=20 > The logic is that if the currently-built package needs to change, it > requires a bump. If there is no currently-built package because of a > build failure, a bump doesn't have a meaningful effect. Said in another way, PORTREVISION bumps happen when an existing package, 4.93.2_6 here, has issues (mostly runtime, but can be other reasons, see the PHB for full list) and it needs to be upgraded to a newer version to work correctly, 4.93.2_8 here. If 4.93.2_6 never existed because it could not be built, well, the most anybody ever had was 4.93.2_5, and once 4.93.2_6 finally builds, it will get updated correctly. --=20 Mathieu Arnold --ragng7dcmjr4gi3y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAl4TuN9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkgqlg/+LmIfTaILP82Ns2irLrgDn+GYEdrgoJHw0RXaxbKCI44g5ZREtrb83Zsw xxT7B/idAnQqKhkswmuGBqbkkjqKZ/nqbHaoXqubAPT/u4wM1LUI7Kj39ogfxKm2 itHU+fFGEZJdM8NkjCP+01OPiWCETipCkmyX8POWyaSX9UoRyg7knWoB5+OCXmxr jOUCw79UW8fxXj+TSh10APytKh5CBjf5POpyfdUgwTBRyUfG5nEHX1DZfDwGSctH D26T7EE06hL4O/v61QllX3ycpgklJ/i6XDNJHLQ45VK+uO+6+2Sz0p8VbCL7L9Es aYGcltUrWGuLSHKFQcJo8A1E/4DhPZ7ISV8uReWJeTGeeHQtpHKJdGN4Oa5cjTxs uttObGQ/i1ehiSBkCN6Bkocwyu0mfVn4ILIvP3UmuybZMV9i6rybJzQfyM6Z6B5r 1P2zvAdlluNy0ZuTRKuPyQ2rsM/wS+tFk1hMFad/GY4025LOJ1uFWX25qO3du1o9 yFpTDSKcYjKZiz2cOb2wYA0A9Nkr/DSP9XhHcyf7bnPTFsWsJx9k9bhPyT4fvxoi 4MuUrHkGf0vcx3SseNPQ9sjSUkpuboG1Ik7N/i1yvHJarwEg9HJpEBZsw9fG+aS9 ekfRvAyc240AbvDLEa2SuKN7ugYixT4TJG2Q5rKU42T3N5n4QNM= =A6Ap -----END PGP SIGNATURE----- --ragng7dcmjr4gi3y--