From owner-freebsd-usb@FreeBSD.ORG Sat Jan 26 20:19:36 2008 Return-Path: Delivered-To: freebsd-usb@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BB2B416A419 for ; Sat, 26 Jan 2008 20:19:36 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe07.swip.net [212.247.154.193]) by mx1.freebsd.org (Postfix) with ESMTP id B58BE13C465 for ; Sat, 26 Jan 2008 20:19:35 +0000 (UTC) (envelope-from hselasky@c2i.net) X-Cloudmark-Score: 0.000000 [] Received: from [193.217.102.3] (account mc467741@c2i.net HELO [10.0.0.122]) by mailfe07.swip.net (CommuniGate Pro SMTP 5.1.13) with ESMTPA id 781583962; Sat, 26 Jan 2008 21:19:33 +0100 From: Hans Petter Selasky To: freebsd-usb@freebsd.org Date: Sat, 26 Jan 2008 21:20:23 +0100 User-Agent: KMail/1.9.7 References: <200801262003.m0QK3EtF012574@www.freebsd.org> In-Reply-To: <200801262003.m0QK3EtF012574@www.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200801262120.25261.hselasky@c2i.net> Cc: freebsd-gnats-submit@freebsd.org, Ivan Voras Subject: Re: usb/120017: CS5536 (AMD Geode) USB 2.0 quirk X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jan 2008 20:19:36 -0000 On Saturday 26 January 2008, Ivan Voras wrote: > >Number: 120017 > >Category: usb > >Synopsis: CS5536 (AMD Geode) USB 2.0 quirk > >Confidential: no > >Severity: serious > >Priority: medium > >Responsible: freebsd-usb > >State: open > >Quarter: > >Keywords: > >Date-Required: > >Class: sw-bug > >Submitter-Id: current-users > >Arrival-Date: Sat Jan 26 20:10:02 UTC 2008 > >Closed-Date: > >Last-Modified: > >Originator: Ivan Voras > >Release: 7-STABLE > >Organization: > >Environment: > > FreeBSD ursaminor.cosmos 7.0-PRERELEASE FreeBSD 7.0-PRERELEASE #3: Fri Jan > 25 00:20:32 CET 2008 > ivoras@ursaminor.cosmos:/usr/obj/usr/src/sys/URSAMINOR i386 > > >Description: > > A quirk has to be made so USB 2.0 (EHCI) works on CS5536 (embedded AMD > Geode companion chip) controller. > > >How-To-Repeat: > > Boot FreeBSD 7 or 8 on a suitable machine (e.g. fit-pc), observe the > message "ehci0: pre-2.0 USB rev". > > >Fix: > > Patch supplied. > > Patch attached with submission follows: > > --- patch.txt begins here --- > --- usb_/ehci_pci.c 2008-01-26 18:42:11.000000000 +0100 > +++ usb/ehci_pci.c 2008-01-26 18:50:20.000000000 +0100 > @@ -99,6 +99,8 @@ > /* AMD */ > #define PCI_EHCI_DEVICEID_8111 0x10227463 > static const char *ehci_device_8111 = "AMD 8111 USB 2.0 controller"; > +#define PCI_EHCI_DEVICEID_CS5536 0x20951022 > +static const char *ehci_device_cs5536 = "AMD CS5536 (Geode) USB 2.0 > controller"; > > /* ATI */ > #define PCI_EHCI_DEVICEID_SB200 0x43451002 > @@ -214,6 +216,8 @@ > return (ehci_device_m5239); > case PCI_EHCI_DEVICEID_8111: > return (ehci_device_8111); > + case PCI_EHCI_DEVICEID_CS5536: > + return (ehci_device_cs5536); > case PCI_EHCI_DEVICEID_SB200: > return (ehci_device_sb200); > case PCI_EHCI_DEVICEID_SB400: > @@ -293,6 +297,10 @@ > case PCI_USBREV_1_1: > sc->sc_bus.usbrev = USBREV_UNKNOWN; > device_printf(self, "pre-2.0 USB rev\n"); > + if (pci_get_devid(self) == PCI_EHCI_DEVICEID_CS5536) { > + device_printf(self, "Quirk for CS5536 USB 2.0 enabled\n"); > + break; > + } > return ENXIO; > case PCI_USBREV_2_0: > sc->sc_bus.usbrev = USBREV_2_0; > > --- patch.txt ends here --- > Hi, Do you know if the EHCI chip used is compliant to USBREV_2_0 ? --HPS