From owner-freebsd-current Tue Nov 13 14: 0:39 2001 Delivered-To: freebsd-current@freebsd.org Received: from InterJet.elischer.org (c421509-a.pinol1.sfba.home.com [24.7.86.9]) by hub.freebsd.org (Postfix) with ESMTP id B006F37B41C for ; Tue, 13 Nov 2001 14:00:16 -0800 (PST) Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id NAA99860; Tue, 13 Nov 2001 13:45:28 -0800 (PST) Date: Tue, 13 Nov 2001 13:45:25 -0800 (PST) From: Julian Elischer To: Jan Stocker Cc: freebsd-current@FreeBSD.org Subject: Re: struct thread In-Reply-To: <1005687275.738.32.camel@twoflower> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG do they need user.h? On 13 Nov 2001, Jan Stocker wrote: > Wine includes sys/user.h which includes sys/proc.h. The configure skript > determines the existence, but it isnt really needed to compile.... Maybe > other systems defines here some needful stuff which is included > somewhere else in FreeBSD? > > Jan > > > On Tue, 2001-11-13 at 21:32, Julian Elischer wrote: > > The trouble is that proc.h is not supposed to be exporting anything to > > userland.. (with the exception of hacks like 'ps' but they are a > > special category. > > > > It is kernel internal definitions.. > > > > Why is wine including it? > > If there is something in it that is needed by wine then we need to think > > about why it needs a kernel internal definition, and maybe whether > > we shouldn't move it somewhere else that IS exported.. > > > > > > On Tue, 13 Nov 2001, Jan Stocker wrote: > > > > > FYI: Ive posted an article to comp.emulators.ms-windows.wine about compiling > > > errors for wine. This is caused by an redefinition of "struct thread". This > > > is the state at present: > > > > > > > > > > > > From: kargls@home.com (Steven G. Kargl) > > > Subject: Re: Compile errors with FreeBSD 5.0 > > > Newsgroups: comp.emulators.ms-windows.wine > > > > > > In article , > > > Ove Kaaven writes: > > > > > > > >> Jan Stocker wrote: > > > >> > Hi, > > > >> > the current version of FreeBSD (5.0) has a common header which defines > > > >> > struct thread, so there will be an redefinition and nothing works. I > > > >> > think you shall rename your stuff from thread.h to something like > > > wine_thre > > > >> > to get out of this trouble. > > > > > > > > I'd rather say that the problem is FreeBSD. System headers should not > > > > pollute the namespace of applicatio. The glibc headers take great care to > > > > avoid polluting the namespace, but FreeBSD is starting to look like it > > > > thinks that it can define any common name, and if there's a collision > > > > because of that carelessness, they tell all the apps to rename their > > > > symbols, instead of fixing the OS. > > > > > > Can you elaborate? The application is pulling in the system > > > header sys/proc.h where struct thread is defined. If an > > > application purposely pulls in a system header file, how can > > > the system header pollute the namespace of the application > > > when the applications requests the information in that header? > > > > > > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > > > with "unsubscribe freebsd-current" in the body of the message > > > > > > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > > with "unsubscribe freebsd-current" in the body of the message > > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message