Date: Sun, 28 Oct 2012 14:26:46 -0700 From: Rui Paulo <rpaulo@felyko.com> To: Andre Oppermann <andre@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r242263 - head/sys/netinet Message-ID: <0220FA6E-FFCB-4489-BF57-3493C2531DD7@felyko.com> In-Reply-To: <201210281920.q9SJKNS0081242@svn.freebsd.org> References: <201210281920.q9SJKNS0081242@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 28 Oct 2012, at 12:20, Andre Oppermann <andre@FreeBSD.org> wrote: > Author: andre > Date: Sun Oct 28 19:20:23 2012 > New Revision: 242263 > URL: http://svn.freebsd.org/changeset/base/242263 >=20 > Log: > Add SACK_PERMIT to the list of TCP options that are switched off = after > retransmitting a SYN three times. >=20 > MFC after: 2 weeks >=20 > Modified: > head/sys/netinet/tcp_timer.c >=20 > Modified: head/sys/netinet/tcp_timer.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/netinet/tcp_timer.c Sun Oct 28 19:16:22 2012 = (r242262) > +++ head/sys/netinet/tcp_timer.c Sun Oct 28 19:20:23 2012 = (r242263) > @@ -585,7 +585,7 @@ tcp_timer_rexmt(void * xtp) > * unknown-to-them TCP options. > */ > if ((tp->t_state =3D=3D TCPS_SYN_SENT) && (tp->t_rxtshift =3D=3D = 3)) > - tp->t_flags &=3D ~(TF_REQ_SCALE|TF_REQ_TSTMP); > + tp->t_flags &=3D = ~(TF_REQ_SCALE|TF_REQ_TSTMP|TF_SACK_PERMIT); > /* > * If we backed off this far, our srtt estimate is probably = bogus. > * Clobber it so we'll take the next rtt measurement as our = srtt; Do you have any data regarding this commit or you're just trying to make = sure the SACK option follows the same behaviour of the WSCALE/TSTMP = options? Regards, -- Rui Paulo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0220FA6E-FFCB-4489-BF57-3493C2531DD7>