From nobody Sun Mar 22 10:06:28 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fdsRQ3kkqz6WHyL; Sun, 22 Mar 2026 10:07:14 +0000 (UTC) (envelope-from freebsd@walstatt-de.de) Received: from smtp052.goneo.de (smtp052.goneo.de [85.220.129.60]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4fdsRQ1L4bz3t2t; Sun, 22 Mar 2026 10:07:14 +0000 (UTC) (envelope-from freebsd@walstatt-de.de) Authentication-Results: mx1.freebsd.org; none Received: from hub1.goneo.de (hub1.goneo.de [IPv6:2001:1640:5::8:52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp5.goneo.de (Postfix) with ESMTPS id 7ED3A2400A4; Sun, 22 Mar 2026 11:07:12 +0100 (CET) Received: from hub1.goneo.de (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by hub1.goneo.de (Postfix) with ESMTPS id A51152400C0; Sun, 22 Mar 2026 11:07:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walstatt-de.de; s=DKIM001; t=1774174030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Gslt3owHYXdGOhxMjpllAAoIzU3354p7VRcOE4ApZlk=; b=eHxWJqRkLruXdMCnd1Ex9K7jtR2tsT9A6GBR0TkYBB2eDLsqJYMwZ2+miyraj5/5jGF9j1 +NWw7JNwkk1i1nr03RflUDl3gZ5YRPQSvk448j3b4sQifOcRJEU4TdHECMg88Rf59IP4tR GxQhFMwDYVXKKbFAI2MUVlro2Row9Ek/PjA1HPDStsmjzTg4ZyTfr+angFxT4GCFARDwY1 8lzbfHnnnP1TbVH+w58xwYqMCeU6Vy1ivJf4mfnHUJlQGVWDiveK6dd0/xAKVIpJWOZctK TMGX1eS4s0wV5vrSD/YnuVG9vNC/uZH5y/vrz+EMLUQJXViiWkDzjsZlBvMymA== Received: from thor.sb211.local (dynamic-2a02-3100-1969-3f02-fc6b-82fb-c0d4-3b70.310.pool.telefonica.de [IPv6:2a02:3100:1969:3f02:fc6b:82fb:c0d4:3b70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hub1.goneo.de (Postfix) with ESMTPSA id 458292400A5; Sun, 22 Mar 2026 11:07:10 +0100 (CET) Date: Sun, 22 Mar 2026 11:06:28 +0100 From: A FreeBSD User To: Konstantin Belousov Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 1ba29614c4ce - main - amd64: revert back struct trapframe to the pre-FRED definition Message-ID: <20260322110655.5166a078@thor.sb211.local> In-Reply-To: <69bf1dbc.27145.5b461258@gitrepo.freebsd.org> References: <69bf1dbc.27145.5b461258@gitrepo.freebsd.org> X-Mailer: Claws Mail 3.21.0 (GTK+ 2.24.33; amd64-portbld-freebsd16.0) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/HKvM8OukEEzqVsyO6AvXUry"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Rspamd-UID: 218401 X-Rspamd-UID: 5c0b0e X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:25394, ipnet:85.220.128.0/17, country:DE] X-Rspamd-Queue-Id: 4fdsRQ1L4bz3t2t X-Spamd-Bar: ---- --Sig_/HKvM8OukEEzqVsyO6AvXUry Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Tage des Herren Sat, 21 Mar 2026 22:37:48 +0000 Konstantin Belousov schrieb: > The branch main has been updated by kib: >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3D1ba29614c4ce5e261ade0bd7de= f94079b7b9647a >=20 > commit 1ba29614c4ce5e261ade0bd7def94079b7b9647a > Author: Konstantin Belousov > AuthorDate: 2026-03-21 22:26:48 +0000 > Commit: Konstantin Belousov > CommitDate: 2026-03-21 22:37:27 +0000 >=20 > amd64: revert back struct trapframe to the pre-FRED definition > =20 > Trying to use the grown struct trapframe for IDT case broke in cases > where code supposed that hardware consumed sizeof(struct trapframe) of > the stack space when delivering interrupt or exception. In particula= r, > this was broken for #NM/#DB/#MC. Naive attempt of using IDT-trapframe > size for stack consumption caused later problems with larger C type. > =20 > Instead of pretending that IDT event delivery pushed two never-access= ed > doubleword to the stack, keep it honest and provide separate type for > the FRED interrupt frame, i.e. struct trapframe_fred. > =20 > Convert between trapframe_fred and trapframe can be done by trivial p= ointer > arithmetic. > =20 > Sponsored by: The FreeBSD Foundation > MFC after: 1 week > --- > sys/x86/include/frame.h | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/sys/x86/include/frame.h b/sys/x86/include/frame.h > index a6444d55cfaf..b8e090ff95d0 100644 > --- a/sys/x86/include/frame.h > +++ b/sys/x86/include/frame.h > @@ -152,6 +152,10 @@ struct trapframe { > uint16_t tf_ss; > uint16_t tf_fred_evinfo1; > uint32_t tf_fred_evinfo2; > +}; > + > +struct trapframe_fred { > + struct trapframe tf_idt; > /* two long words added by FRED */ > uint64_t tf_fred_evdata; > uint64_t tf_fred_zero1; >=20 ... this fixes in my case mentioned freezing/rebooting issues. Thank you very much. Kind regards oh --=20 A FreeBSD user --Sig_/HKvM8OukEEzqVsyO6AvXUry Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRQheDybVktG5eW/1Kxzvs8OqokrwUCab+/PwAKCRCxzvs8Oqok r7VNAP0Zr3nZdL49iR5uDP2S2JT3FZLrf88AHwC7IkLq6r1+eQEA48rdin65dN7m zr8qanU+e4OHLP5Uogx+uNGqx92iOwg= =Vqpx -----END PGP SIGNATURE----- --Sig_/HKvM8OukEEzqVsyO6AvXUry--