From owner-freebsd-net@FreeBSD.ORG Tue Apr 2 14:20:39 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 3BD94E75 for ; Tue, 2 Apr 2013 14:20:39 +0000 (UTC) (envelope-from fodillemlinkarim@gmail.com) Received: from mail-ia0-x229.google.com (mail-ia0-x229.google.com [IPv6:2607:f8b0:4001:c02::229]) by mx1.freebsd.org (Postfix) with ESMTP id 0AE11710 for ; Tue, 2 Apr 2013 14:20:39 +0000 (UTC) Received: by mail-ia0-f169.google.com with SMTP id j5so361393iaf.28 for ; Tue, 02 Apr 2013 07:20:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=KH17o1JDcY1kYx2HZQjO3slw7Ug2eIN9sMQ7GWrkyZI=; b=GlAwS2nmuC5saCkzfq07Ik68uj1EUsw/9Lp7utIUL1sAVMIzq88n3mriOkP+sPyUcM /MvfnFr8JszuEzcZ4Wrj3VvJdBIEZHnixExmojO+K4Qhw8gqFtp7S+nSuFGXPSYpq81V +WQroSmwPOG6D8aqnTKSWoUpAtciWrhpSxsrqsMoAof0T7CZy4HqgQOfUv2ZXbyfQikl 2ROvlTCxqP98YVtaYcv1LU4bmzMshfjw8bQXuYPBBRzXZGu6xwHLYGI7vddgU2bmdbKv tC4AcTPE5TJQOHEz2UTi/Mz1nVwml5sA2iG6Co/C3puDrn964+w9GBN1WYMng0JyFGll WDLg== X-Received: by 10.50.150.167 with SMTP id uj7mr5316473igb.1.1364912438578; Tue, 02 Apr 2013 07:20:38 -0700 (PDT) Received: from [192.168.1.73] ([208.85.112.101]) by mx.google.com with ESMTPS id ur12sm622356igb.8.2013.04.02.07.20.36 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 02 Apr 2013 07:20:37 -0700 (PDT) Message-ID: <515AE933.7020806@gmail.com> Date: Tue, 02 Apr 2013 10:20:35 -0400 From: Karim Fodil-Lemelin User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 MIME-Version: 1.0 To: Nick Rogers Subject: Re: igb and ALTQ in 9.1-rc3 References: <1355177348.71087.YahooMailClassic@web121601.mail.ne1.yahoo.com> <50C6656E.3020601@gmail.com> <20121211075853.GU48639@FreeBSD.org> <5159AB72.1050202@gmail.com> <515ADACD.8010108@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "freebsd-net@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2013 14:20:39 -0000 Hi Nick, You need to set the ALTQF_READY flag inside the igb driver. Make sure you have something like this in if_igb.c: ifp->if_start = igb_start; IFQ_SET_MAXLEN(&ifp->if_snd, adapter->num_tx_desc - 1); ifp->if_snd.ifq_drv_maxlen = adapter->num_tx_desc - 1; IFQ_SET_READY(&ifp->if_snd); The call to IFQ_SET_READY() is what will enable ALTQ on your device. Regards, Karim. On 02/04/2013 9:58 AM, Nick Rogers wrote: > On Tuesday, April 2, 2013, Karim Fodil-Lemelin wrote: > >> Hi Nick, >> >> Can you verify that you have at least one of those options in your kernel >> config file: >> >> ALTQ_CBQ >> ALTQ_PRIQ >> ALTQ_HFSC > > Yes I have hfsc included in the kernel. I have other machines using altq > with em(4) interfaces and similar pf configurations on the same kernel that > work fine. > > >> Regards, >> >> Karim. >> >> On 01/04/2013 8:22 PM, Nick Rogers wrote: >> >> On Mon, Apr 1, 2013 at 8:44 AM, Karim Fodil-Lemelin >> wrote: >> >> Hi Jack, >> >> I think this would help M. Rogers case as we have done something similar >> here to circumvent the issue and it seems to work well. I would also add >> that when using ALTQ we found it much more stable to set the number of >> queues to 1: >> >> static int igb_num_queues = 1; >> >> Our approach consisted in keeping igb_start() defined and using >> igb_mq_start_locked() inside it instead of igb_start_locked(). >> >> Regards, >> >> Karim. >> >> Thanks for the pointer. >> >> I've been working with Jack to get a fix for this in that downgrades >> the stack to the older if_start/non-multiqueue interface. See the >> following two commits he made to HEAD. >> >> http://svnweb.freebsd.org/**base/head/sys/dev/e1000/if_** >> igb.c?revision=248906&view=**markup >> http://svnweb.freebsd.org/**base/head/sys/dev/e1000/if_** >> igb.h?revision=248908&view=**markup >> >> I've applied these changes to latest 9.1-STABLE src and included the >> IGB_LEGACY_TX in the e1000 Makefile. So far I am not having any luck >> getting pfctl to think igb is supported. >> >> i.e. I am still getting the following when loading my PF config: >> pfctl -f /etc/pf.conf >> pfctl: igb0: driver does not support altq >> >> Can anyone comment on if the above referenced changes that Jack made >> should be sufficient to get ALTQ working with igb? >> >> The error is coming from src/contrib/pf/pfctl/pfctl.c. There seems to >> be a function that checks if the driver is supported or not but I >> cannot figure out why the ioctl is not returning a device. >> >> Here is the device check code for reference: >> >> int >> pfctl_add_altq(struct pfctl *pf, struct pf_altq *a) >> { >> if (altqsupport && >> (loadopt & PFCTL_FLAG_ALTQ) != 0) { >> memcpy(&pf->paltq->altq, a, sizeof(struct pf_altq)); >> if ((pf->opts & PF_OPT_NOACTION) == 0) { >> if (ioctl(pf->dev, DIOCADDALTQ, pf->paltq)) { >> if (errno == ENXIO) >> errx(1, "qtype not configured"); >> else if (errno == ENODEV) >> errx(1, "%s: driver does not >> support " >> "altq", a->ifname); >> else >> err(1, "DIOCADDALTQ"); >> } >> } >> pfaltq_store(&pf->paltq->altq)**; >> } >> return (0); >> } >> >> >> >> >> >> On 28/03/2013 7:16 PM, Jack Vogel wrote: >> >> Have been kept fairly busy with other matters, one thing I could do short >> term is >> change the defines in igb the way I did in the em driver so you could >> still >> define >> the older if_start entry. Right now those are based on OS version and so >> you will >> automatically get if_transmit, but I could change it to be IGB_LEGACY_TX >> or >> so, >> and that could be defined in the Makefile. >> >> Would this help? >> >> Jack >> >> >> On Thu, Mar 28, 2013 at 2:31 PM, Nick Rogers wrote: >> >> On Tue, Dec 11, 2012 at 1:09 AM, Jack Vogel wrote: >> >> On Mon, Dec 10, 2012 at 11:58 PM, Gleb Smirnoff >> >> wrote: >> >> On Mon, Dec 10, 2012 at 03:31:19PM -0800, Jack Vogel wrote: >> J> UH, maybe asking the owner of the driver would help :) >> J> >> J> ... and no, I've never been aware of doing anything to stop >> >> supporting >> >> > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"