From owner-cvs-all Mon Aug 9 0: 8:24 1999 Delivered-To: cvs-all@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.40.131]) by hub.freebsd.org (Postfix) with ESMTP id 76FF714F39; Mon, 9 Aug 1999 00:08:16 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.9.3/8.9.2) with ESMTP id JAA22252; Mon, 9 Aug 1999 09:03:42 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Bruce Evans Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, green@FreeBSD.org Subject: Re: cvs commit: src/libexec/telnetd sys_term.c In-reply-to: Your message of "Mon, 09 Aug 1999 16:58:14 +1000." <199908090658.QAA08926@godzilla.zeta.org.au> Date: Mon, 09 Aug 1999 09:03:42 +0200 Message-ID: <22250.934182222@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk In message <199908090658.QAA08926@godzilla.zeta.org.au>, Bruce Evans writes: >>>> Log: >>>> Add a missing include (sys/queue.h for sys/tty.h SLIST usage.) >>>> >>>> Revision Changes Path >>>> 1.22 +2 -1 src/libexec/telnetd/sys_term.c >>> >>>Wrong fix. is not a prerequisite of (recent >>>breakage of doesn't count). > >>Yeah, I think the right fix is to include in >> and remove all explicit includes to it. > >This would be >1) nonstandard. POSIX.1 only reserves names ending in _t for . >2) bogus. doesn't declare any types. > >Including in would work in the kernel but >wouldn't help in applications. There is nothing better than including > in all headers that use it. According to my list of >prerequisites, this is already done everywhere except . Ok, so I guess jordans commit DTRT then. Could you put a comment in sys/queue.h which says that this is the way to use it ? -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." FreeBSD -- It will take a long time before progress goes too far! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message