From owner-freebsd-bugs@FreeBSD.ORG Sat Jul 31 05:30:04 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8FEF5106567E for ; Sat, 31 Jul 2010 05:30:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 530818FC18 for ; Sat, 31 Jul 2010 05:30:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o6V5U4cO002328 for ; Sat, 31 Jul 2010 05:30:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o6V5U40B002325; Sat, 31 Jul 2010 05:30:04 GMT (envelope-from gnats) Resent-Date: Sat, 31 Jul 2010 05:30:04 GMT Resent-Message-Id: <201007310530.o6V5U40B002325@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Andy Farkas Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6E81D106566C for ; Sat, 31 Jul 2010 02:57:23 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 5D6C68FC14 for ; Sat, 31 Jul 2010 02:57:23 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o6V2vNAT039889 for ; Sat, 31 Jul 2010 02:57:23 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o6V2vNkY039888; Sat, 31 Jul 2010 02:57:23 GMT (envelope-from nobody) Message-Id: <201007310257.o6V2vNkY039888@www.freebsd.org> Date: Sat, 31 Jul 2010 02:57:23 GMT From: Andy Farkas To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/149130: grdc(6) stops after n/2 seconds X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Jul 2010 05:30:04 -0000 >Number: 149130 >Category: bin >Synopsis: grdc(6) stops after n/2 seconds >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Jul 31 05:30:03 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Andy Farkas >Release: 8.1-STABLE >Organization: >Environment: FreeBSD 8.1-STABLE #0: Tue Jul 27 21:37:41 EST 2010 >Description: man 6 grdc states "With an optional numeric argument n it stops after n seconds (default never)." Currently, if n is provided, grdc stops before n/2 seconds. This patch fixes the problem and also makes sure it stops *after* n seconds like the man page says. >How-To-Repeat: > time grdc 10 .. 4.16 real 0.05 user 0.00 sys > >Fix: --- /usr/src/games/grdc/grdc.c 2010-03-12 10:51:13.000000000 +1000 +++ ./grdc.c 2010-07-31 12:43:57.000000000 +1000 @@ -204,9 +204,9 @@ ts.tv_nsec = 0; } nanosleep(&ts, NULL); - now = ts.tv_sec + 1; + ++now; } else - now = ts.tv_sec; + now = ts.tv_sec + 1; if (sigtermed) { standend(); clear(); @@ -214,7 +214,7 @@ endwin(); errx(1, "terminated by signal %d", (int)sigtermed); } - } while(--n); + } while(n--); standend(); clear(); refresh(); >Release-Note: >Audit-Trail: >Unformatted: