From owner-svn-ports-all@freebsd.org Tue Jan 9 18:19:33 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 372ACE6849F; Tue, 9 Jan 2018 18:19:33 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id CB2FD69352; Tue, 9 Jan 2018 18:19:32 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with ESMTPA id YyUhelp7EZ8gBYyUieSxXU; Tue, 09 Jan 2018 11:19:30 -0700 X-Authority-Analysis: v=2.2 cv=M/g9E24s c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=RgaUWeydRksA:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=P5QcZynSAAAA:8 a=ylX8_5QwAAAA:8 a=ytHi77vFxDgFs58Ze3AA:9 a=SYV8sRIs0-Ud3-Rl:21 a=TOVWyqvKoQ2AM8px:21 a=CjuIK1q_8ugA:10 a=YiiQgHQYhGQA:10 a=n1SSatEbuWAA:10 a=4CSOS4JRf9P8am785wYA:9 a=bdpbgg7kMtQtkiiA:21 a=QFBJkkz8BRj20mo1:21 a=q9EXasxVCnrV-4PO:21 a=_W_S_7VecoQA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 a=Rz8tmApJkS3Yhhjwa_G9:22 a=iZyaqenN3ho1YRgQTAlP:22 Received: from [10.168.3.146] (S0106d4ca6d8943b0.gv.shawcable.net [70.66.132.207]) by spqr.komquats.com (Postfix) with ESMTPSA id 657C6BDE6; Tue, 9 Jan 2018 10:19:26 -0800 (PST) MIME-Version: 1.0 From: Cy Schubert Subject: RE: svn commit: r458000 - head/www/nginx Date: Tue, 9 Jan 2018 10:19:30 -0800 To: Adam Weinberger , "Sergey A. Osokin" CC: Mathieu Arnold , "v@fatpipi.com" , Jochen Neumeister , "ports-committers@freebsd.org" , "svn-ports-all@freebsd.org" , "svn-ports-head@freebsd.org" Message-Id: <20180109181926.657C6BDE6@spqr.komquats.com> X-CMAE-Envelope: MS4wfJjJ1oqg1IrhgihZgAk5Fj+JfZzdWxFRWXaD2xrinh/RTcHl4Ws5jLQGYnKqiiMfBWhQnyk9xHhL1u9Kmv8vuFGqujZ8sORkKI5LG5m7XoIirV8K+AiL vNRV4f7fOmMg8nDcpqDeIcTTKXlstguO5Oz56cj8FRkfKYzWkYt0uvLgqMSgvToxDbcFfzGAr8biNX4uwarKN96ec0/LgUjiLxr8fI6OCirjDb0jPvTlYTzw cbYaXIjuAQw0+BoJn8sv68Lz8tvFywm21SivRcOyE/aeZeFZRWdZGTpvUBrlfY3vpaOG9gzbYM5/c89FgdKz665lMFYVePtbFMZjIFlGPaeTvoflN1wz1e9S WpgTyNI/3mi2m2YfIhEm2gsBo+kzrW1a+oCa2Jn69QGGNHL3IlGH+uXE0XKyq9bCZ/ktoUGWpF3CrH7tW7LYM35kvY2iOMsZYv6HySt9x9/wh1AhYNk= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 18:19:33 -0000 The reason is people can set their own poudriere options. For instance, if = I enabled a module in my poudriere, I need it rebuilt when it is updated. O= therwise we work from a paradigm of only support for default options built = on the FreeBSD cluster. It is illogical to think otherwise. POERTREVISION bump is required and expected. --- Sent using a tiny phone keyboard. Apologies for any typos and autocorrect. Also, this old phone only supports top post. Apologies. Cy Schubert or The need of the many outweighs the greed of the few. --- -----Original Message----- From: Adam Weinberger Sent: 06/01/2018 07:15 To: Sergey A. Osokin Cc: Mathieu Arnold; v@fatpipi.com; Jochen Neumeister; ports-committers@free= bsd.org; svn-ports-all@freebsd.org; svn-ports-head@freebsd.org Subject: Re: svn commit: r458000 - head/www/nginx > On 6 Jan, 2018, at 6:41, Sergey A. Osokin wrote: > > On Thu, Jan 04, 2018 at 08:30:55AM +0100, Mathieu Arnold wrote: >> Le 04/01/2018 ?? 02:56, Vanilla Hsu a ??crit : >>> auth-digest is not default module, so you don't need to bump >>> PORTREVISION. >> >> Yes you do. >> To quote >> https://www.freebsd.org/doc/en/books/porters-handbook/makefile-naming.ht= ml#makefile-portrevision >> : >> >> PORTREVISION must be increased each time a change is made to the >> port that changes the generated package in any way. That includes >> changes that only affect a package built with non-default options. > > I've tried to find a commit in doc area to better understand who and why > did this change. Another question is why this so important change > hasn't been discussed and why committers and community haven't been =20 > notified > about that in advance. Hi Sergey, It's been policy for a long time now, a number of years at least. It does = =20 feel strange at first, but it really does benefit our users in the end. The= =20 reason we have to bump PORTREVISION for non-default options is the same =20 reason we have to bump PORTREVISION for default options. When something =20 changes, build scripts need to know to rebuild the package. There is simply= =20 no way for that to happen unless we tell them to. I know you're not a fan of forcing default option users to rebuild ports =20 when their setup hasn't changed, but the other side of it is that we often = =20 force non-default option users to rebuild when THEIR setup hasn't changed. = =20 It works both ways, and it's just a consequence of our build paradigm. It = =20 has to happen though, every time. # Adam -- Adam Weinberger adamw@adamw.org http://www.adamw.org