Date: Fri, 28 Feb 2014 17:37:50 +0800 (CST) From: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> To: FreeBSD-gnats-submit@freebsd.org Cc: ale@FreeBSD.org Subject: ports/187131: [PATCH] databases/mysql56-client: install missing hash.h to fix build failure of ports which includes sql_common.h Message-ID: <20140228093750.6A5E03657@sunpoet.net> Resent-Message-ID: <201402280940.s1S9e0SG076045@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 187131
>Category: ports
>Synopsis: [PATCH] databases/mysql56-client: install missing hash.h to fix build failure of ports which includes sql_common.h
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Fri Feb 28 09:40:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: Sunpoet Po-Chuan Hsieh
>Release: FreeBSD 10.0-STABLE amd64
>Organization:
The FreeBSD Project
>Environment:
System: FreeBSD bonjour.sunpoet.net 10.0-STABLE FreeBSD 10.0-STABLE #0 r261402: Mon Feb 3 22:35:15
>Description:
${PREFIX}/include/mysql/sql_common.h includes hash.h which is in mysql 5.6.x
source as include/hash.h. However, hash.h was not installed thus some ports
fail to build, e.g. databases/mydumper.
Port maintainer (ale@FreeBSD.org) is cc'd.
Generated with FreeBSD Port Tools 1.00.2014.02.18 (mode: change, diff: SVN)
>How-To-Repeat:
% cd /usr/ports/databases/mysql56-client; make install
% cd /usr/ports/databases/mydumper; make install
...
In file included from /usr/ports/works/usr/ports/databases/mydumper/work/mydumper-0.5.2/binlog.c:27:
/usr/local/include/mysql/sql_common.h:26:10: fatal error: 'hash.h' file not found
#include <hash.h>
^
1 warning and 1 error generated.
*** [CMakeFiles/mydumper.dir/binlog.c.o] Error code 1
% pkg which /usr/local/include/mysql/sql_common.h
/usr/local/include/mysql/sql_common.h was installed by package mysql56-client-5.6.16
>Fix:
--- mysql56-client-5.6.16.patch begins here ---
Index: Makefile
===================================================================
--- Makefile (revision 346473)
+++ Makefile (working copy)
@@ -2,6 +2,7 @@
# $FreeBSD$
PORTNAME= mysql
+PORTREVISION= 1
PKGNAMESUFFIX= 56-client
COMMENT= Multithreaded SQL database (client)
Index: files/patch-include-CMakeLists.txt
===================================================================
--- files/patch-include-CMakeLists.txt (revision 0)
+++ files/patch-include-CMakeLists.txt (working copy)
@@ -0,0 +1,10 @@
+--- include/CMakeLists.txt.orig 2014-01-14 23:38:00.000000000 +0800
++++ include/CMakeLists.txt 2014-02-28 04:51:50.269412818 +0800
+@@ -35,6 +35,7 @@
+
+ SET(HEADERS
+ ${HEADERS_ABI}
++ hash.h
+ my_dbug.h
+ m_string.h
+ my_sys.h
Index: pkg-plist
===================================================================
--- pkg-plist (revision 346473)
+++ pkg-plist (working copy)
@@ -19,6 +19,7 @@
include/mysql/byte_order_generic_x86_64.h
include/mysql/decimal.h
include/mysql/errmsg.h
+include/mysql/hash.h
include/mysql/keycache.h
include/mysql/little_endian.h
include/mysql/m_ctype.h
--- mysql56-client-5.6.16.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140228093750.6A5E03657>