From owner-svn-ports-head@freebsd.org Mon Jan 6 23:36:49 2020 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DA8C91FD2A0; Mon, 6 Jan 2020 23:36:49 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47sBjs5Vsvz4QFf; Mon, 6 Jan 2020 23:36:49 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id B61E91E1F5; Mon, 6 Jan 2020 23:36:49 +0000 (UTC) From: Jan Beich To: Larry Rosenman Cc: Mathieu Arnold , svn-ports-head , Cy Schubert , svn-ports-all , ports-committers , Adam Weinberger Subject: Re: svn commit: r522273 - in head/sysutils/lsof: . files References: <202001062042.006Kg81F048249@repo.freebsd.org> <202001062102.006L2KrM089339@slippy.cwsent.com> <20200106224656.wefyervptxppm4pv@atuin.in.mat.cc> <77126b0704f82ceb1890e4570fd7b1f5@FreeBSD.org> Date: Tue, 07 Jan 2020 00:36:49 +0100 In-Reply-To: <77126b0704f82ceb1890e4570fd7b1f5@FreeBSD.org> (Larry Rosenman's message of "Mon, 06 Jan 2020 16:49:37 -0600") Message-ID: <36cs-jgxa-wny@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jan 2020 23:36:49 -0000 Larry Rosenman writes: > On 01/06/2020 4:46 pm, Mathieu Arnold wrote: > >> On Mon, Jan 06, 2020 at 02:19:58PM -0700, Adam Weinberger wrote: >>> On Mon, Jan 6, 2020 at 2:05 PM Larry Rosenman wrote: >>> > >>> > On 01/06/2020 3:02 pm, Cy Schubert wrote: >>> > > In message <202001062042.006Kg81F048249@repo.freebsd.org>, Larry >>> > > Rosenman >>> > > write >>> > > s: >>> > >> Author: ler >>> > >> Date: Mon Jan 6 20:42:08 2020 >>> > >> New Revision: 522273 >>> > >> URL: https://svnweb.freebsd.org/changeset/ports/522273 >>> > >> >>> > >> Log: >>> > >> sysutils/lsof: fix build following base r356337. >>> > >> >>> > >> I took the patch from 243122 as it was more correct. >>> > >> >>> > >> PR: 243122, 243083 >>> > >> Submitted by: cy, yasu@utahime.org >>> > >> >>> > >> Added: >>> > >> head/sysutils/lsof/files/patch-dialects_freebsd_dnode2.c >>> > >> (contents, props >>> > >> changed) >>> > >> Modified: >>> > >> head/sysutils/lsof/Makefile >>> > >> >>> > >> Modified: head/sysutils/lsof/Makefile >>> > >> ============================================================================= >>> > >> = >>> > >> --- head/sysutils/lsof/Makefile Mon Jan 6 20:25:36 2020 (r52227 >>> > >> 2) >>> > >> +++ head/sysutils/lsof/Makefile Mon Jan 6 20:42:08 2020 (r52227 >>> > >> 3) >>> > >> @@ -3,7 +3,7 @@ >>> > >> >>> > >> PORTNAME= lsof >>> > >> DISTVERSION= 4.93.2 >>> > >> -PORTREVISION= 6 >>> > >> +PORTREVISION= 8 >>> > > >>> > > Was this needed? The package doesn't change, only fixing the build. >>> > > >>> > >> PORTEPOCH= 8 >>> > >> CATEGORIES= sysutils >>> > >> >>> > >> >>> > >>> > I thought build breaks on the cluster needed a port rev bump... >>> The logic is that if the currently-built package needs to change, >>> it >>> requires a bump. If there is no currently-built package because of a >>> build failure, a bump doesn't have a meaningful effect. >> Said in another way, PORTREVISION bumps happen when an existing >> package, >> 4.93.2_6 here, has issues (mostly runtime, but can be other reasons, >> see >> the PHB for full list) and it needs to be upgraded to a newer >> version to >> work correctly, 4.93.2_8 here. >> If 4.93.2_6 never existed because it could not be built, well, the >> most >> anybody ever had was 4.93.2_5, and once 4.93.2_6 finally builds, it >> will >> get updated correctly. > > It did build, then -CURRENT /usr/src changed out from under it and it > broke. > > I think the PORTREVISION bump here was corret. poudriere rebuilds all packages on OSVERSION (aka __FreeBSD_version) bumps. If lsof worked before ABI (or KBI?) break it'd be rebuilt after, anyway.