From owner-svn-src-all@freebsd.org Sun Mar 29 02:37:29 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 504A726F959; Sun, 29 Mar 2020 02:37:29 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48qfrQ5d6dz419T; Sun, 29 Mar 2020 02:37:25 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pl1-x62b.google.com with SMTP id x1so5209007plm.4; Sat, 28 Mar 2020 19:37:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=xSmNQwXo3TOraw4xjsnA7PTDcpTEK4fE/+dhLhFD8ek=; b=vNTQRLG5XQxYuTThypWKMsTSZ4GFoTee6o21jnwSY/7yzOOa3FRbqITZvBjqllMc5H gXhUJY8uSGyxdqo7B8WwCytsmHF5ZPe5kRjbMHdXxao4EuyxY4igLXuftnAyEAjdUg3/ 6kNd0ZMoCF7lWw0UnZjFSBYjeqvvdRoqj7OfZFF2SP2+R0ZP1zmmUazWLt+9P/9fo4VW 7lUPUx1l4R7hSF1O4HEQktt30kxqoZ5JWeMMCR78hIkYP8ZViKZ3q1BiGT1rH8h9pCiP eJImEIYPoyczrzz0lOl3Yf9RSOq5HPmUewe+/yOLsDq0VY9rdqQXFG8Uz2sSfqPlL3Cy OGPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=xSmNQwXo3TOraw4xjsnA7PTDcpTEK4fE/+dhLhFD8ek=; b=SlanMEZm4WG/OnsqC1CRKw+1J99iuSxC2UrtMQiQ1qZG2HF1Sc33T6aic8u1hWb5Gi wFYGQIW/RC+1+T2Uh9dg+WWklRY/upQH/EcgFsfYb9NcsOGC07fMycM8KFXMi68Aj04+ Xowu4OhjgNpqImqiqvfJ1SvxK6VfgcflMBXumk0TQRaPB8Gkx02hfoDTUi0YMwVd/ScC SMIar2Xn0t4s04NJ6ql797j1/kRf5H33UUnqNJMIQ/fGK+xScR/fXukHbeVcYY6SMOQu 2AjzqffiWtndmDpC3tDvWEUaX38FAUOyhLi1dqTHWxLsSM5Q/9HkBrlRg+zsOLKJikLt s/+A== X-Gm-Message-State: ANhLgQ2cY+qWcM0pefD4Cq+BKXbcn0WQNyA03MNrUMP3ajBGJr9kx3My 4DC2Bh4pq7s21qwRmEfZzvlbnIod4MY= X-Google-Smtp-Source: ADFU+vsDyI9Op8ZRJlTPRJ3A24GWIZLMZsfEHSIDNDrSn7A/EXoGtRYGMzrKEdocboFnz2RuyNnVsA== X-Received: by 2002:a17:90a:32c1:: with SMTP id l59mr8176199pjb.36.1585449435600; Sat, 28 Mar 2020 19:37:15 -0700 (PDT) Received: from [192.168.20.26] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id f15sm7179861pfq.100.2020.03.28.19.37.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 28 Mar 2020 19:37:14 -0700 (PDT) From: Enji Cooper Message-Id: Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) Subject: Re: svn commit: r359385 - head/usr.bin/kyua Date: Sat, 28 Mar 2020 19:37:13 -0700 In-Reply-To: <20200328032209.GA40889@spindle.one-eyed-alien.net> Cc: Enji Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org To: Brooks Davis References: <202003280108.02S18KWc062782@repo.freebsd.org> <20200328032209.GA40889@spindle.one-eyed-alien.net> X-Mailer: Apple Mail (2.3608.60.0.2.5) X-Rspamd-Queue-Id: 48qfrQ5d6dz419T X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Mar 2020 02:37:29 -0000 > On Mar 27, 2020, at 8:22 PM, Brooks Davis wrote: >=20 > On Sat, Mar 28, 2020 at 01:08:20AM +0000, Enji Cooper wrote: >> Author: ngie >> Date: Sat Mar 28 01:08:20 2020 >> New Revision: 359385 >> URL: https://svnweb.freebsd.org/changeset/base/359385 >>=20 >> Log: >> Check in the generated copies of the manpages >>=20 >> These manpages were meant to be templated once per `configure` run. >>=20 >> Given that we're not bound by as many constants, e.g., `--prefix` = isn't >> generally changing for kyua in the base system, having to generate = the >> manpages each build seems slightly less than optimal. >>=20 >> In the event that one's build environment doesn't define `$SH`, the = build >> will also fail until this change is introduced. >>=20 >> Instead of jumping through hoops dealing with shells or permissions, = let's >> just cut to the chase and check the generated copies into the = sourcebase >> under usr.bin/kyua . >=20 > This was the wrong fix. Committing generated manpaged was > 100% the wrong solution and will make extra work in the > future. The correct fix is almost certainly the one attached to > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D245086 = . If = someone > doesn't beat me to it I will revert you wrong and broken commit along > with the followups and commit the correct one (this certainly won't be > until at least tomorrow). I=E2=80=99ll revert my changes. -Enji=