Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 21 Oct 2018 21:46:08 +0200
From:      Jan Beich <jbeich@FreeBSD.org>
To:        Hans Petter Selasky <hps@selasky.org>
Cc:        FreeBSD Ports <freebsd-ports@freebsd.org>
Subject:   Re: Request for commit approval : midi player pro new version
Message-ID:  <5zxv-ozgf-wny@FreeBSD.org>
References:  <ea851291-6ef1-a88e-1bb5-90f43c08242c@selasky.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hans Petter Selasky <hps@selasky.org> writes:

> /usr/ports/audio/midipp
>
> Changes:
> - Added support for quartertones, octotones, hexatones and so on.
> - Added support for bass offset effect.
> - Added support for circle of fifths.
> - Improved support for printing.

Looks OK:
- No in-tree consumers to worry about ABI and PORTREVISION
- No changes to sync from *.pro to port's Makefile
- Builds fine on 10.4 i386/amd64, 11.2 i386/amd64/aarch64/armv6, 12.0 i386/amd64/aarch64/armv7
- Builds fine with QT4=on QT5=off (tested on 10.4 i386)
- QT5/QT4 runtime doesn't crash on startup (tested on 10.4 i386)
- portlint/stage-qa/check-plist are silent

> Approved by:	XXX
                ^^^
jbeich (ports)

--
Disclaimer: I don't use this port.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5zxv-ozgf-wny>