From owner-freebsd-libh  Sat Apr 13 15:48: 1 2002
Delivered-To: freebsd-libh@freebsd.org
Received: from winston.freebsd.org (adsl-64-173-15-98.dsl.sntc01.pacbell.net [64.173.15.98])
	by hub.freebsd.org (Postfix) with ESMTP id 8B11437B405
	for <libh@FreeBSD.ORG>; Sat, 13 Apr 2002 15:47:56 -0700 (PDT)
Received: from winston.freebsd.org (jkh@localhost [127.0.0.1])
	by winston.freebsd.org (8.11.6/8.11.6) with ESMTP id g3DMl2317896;
	Sat, 13 Apr 2002 15:47:02 -0700 (PDT)
	(envelope-from jkh@winston.freebsd.org)
To: The Anarcat <anarcat@anarcat.dyndns.org>
Cc: libh@FreeBSD.ORG
Subject: Re: cflags 
In-Reply-To: Message from The Anarcat <anarcat@anarcat.dyndns.org> 
   of "Sat, 13 Apr 2002 18:01:21 EDT." <20020413220121.GC316@lenny.anarcat.dyndns.org> 
Date: Sat, 13 Apr 2002 15:47:02 -0700
Message-ID: <17892.1018738022@winston.freebsd.org>
From: Jordan Hubbard <jkh@winston.freebsd.org>
Sender: owner-freebsd-libh@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-libh.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-libh>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-libh>
X-Loop: FreeBSD.ORG

If you're going to do this, my only suggestion be that you make sure
CFLAGS is set in something like the following fashion:

CDEBUGFLAGS?= -g
COPTFLAGS?=   -O
CWARNFLAGS?=   -Wall
CFLAGS?= ${CDEBUGFLAGS} ${COPTFLAGS} ${CWARNFLAGS} -pipe

That way you can override all or part of CFLAGS in the environment or
make command line without necessarily interfering with the flags you
don't want to change or care about.

- Jordan

> --ghzN8eJ9Qlbqn3iT
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
> Content-Transfer-Encoding: quoted-printable
> 
> Hi.
> 
> I think it might be a good idea to fix CFLAGS in libh.
> 
> Right now, we don't even use -Wall, which could do good deeds at
> detecting stupid mistakes. On the top of my head, I think we could
> also use -pipe and *maybe* -O.
> 
> Also, note that we're on debugging mode all the way. -g generates much
> bigger code and might not be a good idea to use when generating boot
> floppies.
> 
> People really into it might even try to compile libh with BDEFLAGS!
> Yay.
> 
> Other ideas?
> 
> A.
> 
> --=20
> Thoughtcrime does not entail death: thoughtcrime IS death.
> 
> --ghzN8eJ9Qlbqn3iT
> Content-Type: application/pgp-signature
> Content-Disposition: inline
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.0.6 (FreeBSD)
> Comment: For info see http://www.gnupg.org
> 
> iEYEARECAAYFAjy4qrAACgkQttcWHAnWiGf3OgCeLOIDUlLLjZLMN8XmI4foFDph
> LxUAn0WCzT2M/uidaAi9EPQNCSUUn32p
> =Mlki
> -----END PGP SIGNATURE-----
> 
> --ghzN8eJ9Qlbqn3iT--
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-libh" in the body of the message


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-libh" in the body of the message