From owner-svn-src-all@freebsd.org Fri Feb 1 01:42:27 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 09EEB14BF3CA; Fri, 1 Feb 2019 01:42:27 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6D44885DD5; Fri, 1 Feb 2019 01:42:26 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by mail-lj1-x241.google.com with SMTP id l15-v6so4378084lja.9; Thu, 31 Jan 2019 17:42:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=swUZh/+GwuaB7zn1NohVLeml4QcsZXCf/WhxD/+pV6s=; b=uryxjevDrwiVr4TtUbNqAokk1K4aT+MpvzkjHJtsnewjFADJLdI+A6c48Sc1tHpd3N Y3PTAyGr3yJViRlTe5UrjfnFMFA3hXZ2+MDitrUu8osDAgIKeyd9uDlY9p6s4EwS05f9 +0Uc6V5mYNyjaotz0OHHiHKbwYAw8Fl6sFnEHwcffBt8Y4DBcsbWGcLfPmJpfJWguCts sf88t0sKOmgejFtypYd4M7uwrdjY0A+5bpkSK8G2Oe+Bf3SV4KnQoT3YvpO/1Wa2WrgL QLaqXNVLzdgkYxckgY79gHCd0Tz0aSLxrMxuoPZqVZlB9OFjeVZfCNSJ2/ZRfEfFG5oR +k1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=swUZh/+GwuaB7zn1NohVLeml4QcsZXCf/WhxD/+pV6s=; b=UjJxaSawcyLLGsco/89KcEdArd1AQhP6ccHv1uQz/2Vnh1pEd+7JzB+eOMxXqNMapf 2xYchFdrPDRh2tYmL3iwKcbs/ZQ8Rpo2JDLSvzEsSWcktfd4xOAMYuWkT4Wh0RTLTQ/1 uyrYmoIDyvWK/+a3r7v72GF01xwgA25eV0Rv+y4XggI/nxs4UhChmYphi71QI8nRcmtq jfqrnr5V1vIAdUj1kFdh9XzpnKCxDrROSc9DospUwcnSWUwW5eUQliOPeLnVn86muCVy j05Xaj2TFUC8qNwRKkUj3LFWFUXapOUfceoJc4AzdZZ5agX1Fesgh0XWGXlf7mbFjn3z GAgQ== X-Gm-Message-State: AHQUAubDaHnWgHh0240WRbViJMK/XMmDLMMt5LRI+Hnsu21mADmyDU97 xvRWrNEDNjAyGnM1xMAQmMnT894mKpmFPwV0tv0= X-Google-Smtp-Source: AHgI3IbtDCfZpLRBXasj5658B/jFw/h3loO9OJDvVPLqZxbwgf3bKZUphAOE4xtzRfQRCPU57a67OTY8WbztLQFycl4= X-Received: by 2002:a2e:3a10:: with SMTP id h16-v6mr25404977lja.184.1548985344985; Thu, 31 Jan 2019 17:42:24 -0800 (PST) MIME-Version: 1.0 References: <201901312332.x0VNWJ6o016057@repo.freebsd.org> <20190131234609.GZ24863@kib.kiev.ua> <20190201010117.GA24863@kib.kiev.ua> <20190201012111.GB24863@kib.kiev.ua> In-Reply-To: <20190201012111.GB24863@kib.kiev.ua> Reply-To: araujo@freebsd.org From: Marcelo Araujo Date: Fri, 1 Feb 2019 09:42:13 +0800 Message-ID: Subject: Re: svn commit: r343634 - head/usr.sbin/bhyve To: Konstantin Belousov Cc: Marcelo Araujo , Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 6D44885DD5 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.97)[-0.970,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Feb 2019 01:42:27 -0000 Em sex, 1 de fev de 2019 =C3=A0s 09:21, Konstantin Belousov escreveu: > On Fri, Feb 01, 2019 at 09:05:37AM +0800, Marcelo Araujo wrote: > > Em sex, 1 de fev de 2019 =C3=A0s 09:01, Konstantin Belousov < > kostikbel@gmail.com> > > escreveu: > > > > > On Fri, Feb 01, 2019 at 08:40:11AM +0800, Marcelo Araujo wrote: > > > > Em sex, 1 de fev de 2019 =C3=A0s 08:36, Warner Losh > > > escreveu: > > > > > > > > > > > > > > > > > > > On Thu, Jan 31, 2019, 4:46 PM Konstantin Belousov < > kostikbel@gmail.com > > > > > wrote: > > > > > > > > > >> On Thu, Jan 31, 2019 at 11:32:19PM +0000, Marcelo Araujo wrote: > > > > >> > Author: araujo > > > > >> > Date: Thu Jan 31 23:32:19 2019 > > > > >> > New Revision: 343634 > > > > >> > URL: https://svnweb.freebsd.org/changeset/base/343634 > > > > >> > > > > > >> > Log: > > > > >> > Mostly a cosmetic change to replace strlen with strnlen. > > > > >> This is not cosmetic, and more, for instance the usage() part of > the > > > > >> change > > > > >> does not make any sense to me. > > > > >> > > > > > > > > > > I specifically objected as well and was blown off. What gives? > > > > > > > > > > > > > I have asked you feedback and got none! I will revert the usage() > changes > > > > later then. > > > > > > I noted the usage() chunk because it is the first one in the commit a= nd > > > I stopped after I see the obvious issues with it, not because it is t= he > > > only wrong part. > > > > > > > Are you implying that all the patch is wrong? > > I have no problem to revert it at all if you give me the right reason, = it > > was basically a port from another project that also uses bhyve. > > By default, all uses of strncmp() and strncpy() are bugs. > Your commit message have no explanation what the change fixes/improves. > > So I looked at the second chunk, for smbios_generic_initializer(). It > also seems to be wrong. If template_string[i] length is greater than > SMBIOS_MAX_LENGTH, then the copied string is not nul-terminated. If its > length is less than the constant, then what is the point ? > > I also looked at the third chunk, smbios_type1_initializer(). I cannot > understand the reasoning behind it, at all. > > Only usb_mouse.c is left, I do not expect anything good from it. > Thanks kib, I will recheck the patch and open another review! I will revert this commit in a few. Best, --=20 --=20 Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)