From owner-cvs-all@FreeBSD.ORG Wed Jun 16 22:53:36 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8AD3616A4D0 for ; Wed, 16 Jun 2004 22:53:36 +0000 (GMT) Received: from root.org (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 57A8A43D46 for ; Wed, 16 Jun 2004 22:53:36 +0000 (GMT) (envelope-from nate@root.org) Received: (qmail 36238 invoked by uid 1000); 16 Jun 2004 22:53:37 -0000 Date: Wed, 16 Jun 2004 15:53:37 -0700 (PDT) From: Nate Lawson To: Warner Losh In-Reply-To: <20040616202815.1F8D716A4DE@hub.freebsd.org> Message-ID: <20040616155205.O36231@root.org> References: <20040616202815.1F8D716A4DE@hub.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/bios apm.c apm.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jun 2004 22:53:36 -0000 On Wed, 16 Jun 2004, Warner Losh wrote: > imp 2004-06-16 20:27:50 UTC > > FreeBSD src repository > > Modified files: > sys/i386/bios apm.c apm.h > Log: > o Return ai_batteries as 0xffffffff instead of -1. This is a nop change, but > placates gcc which seems to like to complain about -1 being assigned to > an unsigned value. It is well defined and intended, but since signess bugs > are being hunted just change to 0xffffffff. > o Mask the lower 8 bits, not the lower 4 bits for the ai_capabilities word. > All 8 bits are defined and the 0xf was almost certainly a typo. > o Define APM_UNKNOWN to 0xff for emulation layer. > > Revision Changes Path > 1.142 +2 -2 src/sys/i386/bios/apm.c > 1.4 +1 -0 src/sys/i386/bios/apm.h Thanks! Perhaps you can look at sys/i386/acpica/acpi_machdep.c and use your new #define as well as fix any -1 issues? -Nate