From owner-freebsd-gnome@FreeBSD.ORG Sat Jul 28 19:00:48 2007 Return-Path: Delivered-To: gnome@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 05B7116A41F for ; Sat, 28 Jul 2007 19:00:48 +0000 (UTC) (envelope-from marcus@FreeBSD.org) Received: from creme-brulee.marcuscom.com (marcuscom-pt.tunnel.tserv1.fmt.ipv6.he.net [IPv6:2001:470:1f00:ffff::1279]) by mx1.freebsd.org (Postfix) with ESMTP id 883C413C45D for ; Sat, 28 Jul 2007 19:00:47 +0000 (UTC) (envelope-from marcus@FreeBSD.org) Received: from [IPv6:2001:470:1f00:2464::4] (shumai.marcuscom.com [IPv6:2001:470:1f00:2464::4]) by creme-brulee.marcuscom.com (8.14.1/8.14.1) with ESMTP id l6SJ1hnc074996; Sat, 28 Jul 2007 15:01:43 -0400 (EDT) (envelope-from marcus@FreeBSD.org) From: Joe Marcus Clarke To: "Steven G. Kargl" In-Reply-To: <200707281849.l6SInTQo078788@troutmask.apl.washington.edu> References: <200707281849.l6SInTQo078788@troutmask.apl.washington.edu> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-eg+BzIDkAgIyYQJEE5rp" Organization: FreeBSD, Inc. Date: Sat, 28 Jul 2007 15:00:35 -0400 Message-Id: <1185649236.63289.3.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Evolution 2.10.3 FreeBSD GNOME Team Port X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,NO_RELAYS autolearn=ham version=3.2.1 X-Spam-Checker-Version: SpamAssassin 3.2.1 (2007-05-02) on creme-brulee.marcuscom.com Cc: gnome@FreeBSD.org Subject: Re: ports/114838: devel/gnome-vfs broken without kerberos X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Jul 2007 19:00:48 -0000 --=-eg+BzIDkAgIyYQJEE5rp Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sat, 2007-07-28 at 11:49 -0700, Steven G. Kargl wrote: > marcus@FreeBSD.org wrote: > > Synopsis: devel/gnome-vfs broken without kerberos > >=20 > > State-Changed-From-To: open->closed > > State-Changed-By: marcus > > State-Changed-When: Sat Jul 28 18:03:24 UTC 2007 > > State-Changed-Why:=20 > > Kerberos is part of the default base system, and we do not support > > builds without it. > >=20 >=20 > Then the Makefile should check if WITHOUT_KERBEROS is defined, > and issue an error. Fair enough. However, this check will break INDEX builds on machines that define WITHOUT_KERBEROS (which is legal). I have committed a different check which should accomplish the same thing. The downside of this approach is that it will not handle WITHOUT_KERBEROS defined in src.conf only. Joe >=20 > --- Makefile.orig 2007-07-26 16:15:53.000000000 -0700 > +++ Makefile 2007-07-26 16:18:37.000000000 -0700 > @@ -58,6 +58,10 @@ > USE_FAM=3D yes > .endif > =20 > +.if defined(WITHOUT_KERBEROS)=20 > +.error KERBEROS is required. > +.endif=20 > + > .if exists(${LOCALBASE}/lib/libkrb5.so) > LIB_DEPENDS+=3D krb5:${PORTSDIR}/security/heimdal > .endif >=20 --=20 Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome --=-eg+BzIDkAgIyYQJEE5rp Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQBGq5JSb2iPiv4Uz4cRAtxoAJ9nrkJ5UJtd3MWe1g4l0bnOpB2h7QCgnGe5 vXqT0o3Gc0Z6Dt5Z6YzL7bU= =4kT1 -----END PGP SIGNATURE----- --=-eg+BzIDkAgIyYQJEE5rp--