Date: Sun, 18 Oct 2009 16:01:13 +0200 (CEST) From: Christian Weisgerber <naddy@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Cc: obrien@FreeBSD.org Subject: ports/139720: shells/bash: fix $() parsing Message-ID: <200910181401.n9IE1DJf065071@lorvorc.mips.inka.de> Resent-Message-ID: <200910181410.n9IEA21F043663@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 139720
>Category: ports
>Synopsis: shells/bash: fix $() parsing
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Oct 18 14:10:02 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Christian Weisgerber
>Release: FreeBSD 7.2-STABLE amd64
>Organization:
>Environment:
System: FreeBSD lorvorc.mips.inka.de 7.2-STABLE FreeBSD 7.2-STABLE #0: Sun Oct 18 13:39:23 CEST 2009 naddy@lorvorc.mips.inka.de:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
$() parsing is still broken in bash 4.0.33 as installed by the port.
We need to pass the -y flag to bison. Plain "bison -d parse.y"
outputs parse.tab.c instead of y.tab.c, so y.tab.c is never
regenerated, and the parser fix from patch 001 is effectively not
applied.
[Resent as PR so it doesn't get lost again.]
>How-To-Repeat:
bash -c 'echo $(echo \|)'
>Fix:
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/shells/bash/Makefile,v
retrieving revision 1.115
diff -u -r1.115 Makefile
--- Makefile 19 Sep 2009 22:24:28 -0000 1.115
+++ Makefile 18 Oct 2009 13:28:10 -0000
@@ -9,7 +9,7 @@
PORTNAME= bash
PATCHLEVEL= 33
PORTVERSION= 4.0.${PATCHLEVEL:S/^0//g}
-PORTREVISION?= 0
+PORTREVISION?= 1
CATEGORIES= shells
MASTER_SITES= ${MASTER_SITE_GNU:S/$/:bash/} \
ftp://ftp.cwru.edu/pub/%SUBDIR%/:faq
@@ -94,7 +94,7 @@
CONFIGURE_ENV= CPPFLAGS="${CPPFLAGS}" \
LDFLAGS="${LDFLAGS}" \
- YACC="bison"
+ YACC="bison -y"
.include <bsd.port.pre.mk>
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200910181401.n9IE1DJf065071>