From owner-freebsd-current Tue Aug 8 10: 3:20 2000 Delivered-To: freebsd-current@freebsd.org Received: from ns.yogotech.com (ns.yogotech.com [206.127.123.66]) by hub.freebsd.org (Postfix) with ESMTP id 3B6B037B5CE for ; Tue, 8 Aug 2000 10:03:17 -0700 (PDT) (envelope-from nate@yogotech.com) Received: from nomad.yogotech.com (nomad.yogotech.com [206.127.123.131]) by ns.yogotech.com (8.9.3/8.9.3) with ESMTP id LAA05203; Tue, 8 Aug 2000 11:03:12 -0600 (MDT) (envelope-from nate@nomad.yogotech.com) Received: (from nate@localhost) by nomad.yogotech.com (8.8.8/8.8.8) id LAA28034; Tue, 8 Aug 2000 11:02:53 -0600 (MDT) (envelope-from nate) Date: Tue, 8 Aug 2000 11:02:53 -0600 (MDT) Message-Id: <200008081702.LAA28034@nomad.yogotech.com> From: Nate Williams MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit To: Alfred Perlstein Cc: David Greenman , current@FreeBSD.ORG Subject: Re: Ugly, slow shutdown In-Reply-To: <20000808005100.A4854@fw.wintelcom.net> References: <200008080238.TAA40871@vashon.polstra.com> <200008080558.WAA05458@implode.root.com> <20000808005100.A4854@fw.wintelcom.net> X-Mailer: VM 6.34 under 19.16 "Lille" XEmacs Lucid Reply-To: nate@yogotech.com (Nate Williams) Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > It's not just that, if you always have to cover your behind when > doing tsleep you may wind up masking wakeup bugs. Places like > "vfs_bio.c" line 586 of 3182: > > bp->b_xflags |= BX_BKGRDWAIT; > tsleep(&bp->b_xflags, PRIBIO, "biord", 0); > if (bp->b_xflags & BX_BKGRDINPROG) > panic("bwrite: still writing"); > } > > If replaced by a while() _may_ obscure a buffercache bug. > > Personally I'd like to be able to catch such bugs than let them go > because the API (wakeups can happen at any time) prohibits this. No in a fully threaded world..... Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message