From owner-freebsd-ports-bugs@freebsd.org Sun Mar 6 15:39:13 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0C2BEA09C56 for ; Sun, 6 Mar 2016 15:39:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D77A0A92 for ; Sun, 6 Mar 2016 15:39:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u26FdCrf099202 for ; Sun, 6 Mar 2016 15:39:12 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 207291] net/asterisk-chan_sccp: Version bump to v4.2.3 Date: Sun, 06 Mar 2016 15:39:13 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rakuco@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Mar 2016 15:39:13 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D207291 --- Comment #11 from Raphael Kubo da Costa --- (In reply to Diederik de Groot from comment #10) > (In reply to Raphael Kubo da Costa from comment #9) > I have changed the source code to include "config.h" in both source files, > which should have taken care of the issue reported. > > I am not sure if 9.3 does include iconv in the same way that 10.2 does. B= ut > even if not provided, then configure should have detected that and not set > ICONV_CONST. I have test this on my local system (with and without iconv), > which compiled cleanly. iconv support is a problematic topic: basically in 9.x we still shipped with iconv(3) that used a const in the second argument, which doesn't match most implementations out there. This has been fixed in 10.x+, which is why you didn't see any problems in your tests. Mk/Uses/iconv.mk contains all the ha= iry details that make USES=3Diconv work on all supported FreeBSD versions. The whole build issue is happening because the configure script was conside= ring iconv was not installed even though it is present and must be used. The ICONV_CONST macro was then not being defined anywhere and the compiler thou= ght it was a symbol it did not recognize. This is caused by the way the iconv m4 and autotools code is written: --with-libiconv-prefix=3D${LOCALBASE} (which is what you get with ${ICONV_CONFIGURE_ARG}) is not enough and the iconv(3) detection code only works when iconv's include path and library are passed to the compiler/link= er. This can be fixed by adding a few more variables to the Makefile: CPPFLAGS+=3D-I${ICONV_INCLUDE_PATH} LDFLAGS+=3D -L${LOCALBASE}/lib ${ICONV_LIB} --=20 You are receiving this mail because: You are the assignee for the bug.=