From owner-freebsd-questions@FreeBSD.ORG  Fri Apr 10 19:44:21 2009
Return-Path: <owner-freebsd-questions@FreeBSD.ORG>
Delivered-To: freebsd-questions@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B66BF106566C
	for <freebsd-questions@freebsd.org>;
	Fri, 10 Apr 2009 19:44:21 +0000 (UTC)
	(envelope-from freebsd@edvax.de)
Received: from mx01.qsc.de (mx01.qsc.de [213.148.129.14])
	by mx1.freebsd.org (Postfix) with ESMTP id 6EED48FC21
	for <freebsd-questions@freebsd.org>;
	Fri, 10 Apr 2009 19:44:21 +0000 (UTC)
	(envelope-from freebsd@edvax.de)
Received: from r55.edvax.de (port-92-196-97-234.dynamic.qsc.de [92.196.97.234])
	by mx01.qsc.de (Postfix) with ESMTP id 0667D1FE;
	Fri, 10 Apr 2009 21:44:19 +0200 (CEST)
Received: from r55.edvax.de (localhost [127.0.0.1])
	by r55.edvax.de (8.14.2/8.14.2) with SMTP id n3AJiE0Q001920;
	Fri, 10 Apr 2009 21:44:14 +0200 (CEST)
	(envelope-from freebsd@edvax.de)
Date: Fri, 10 Apr 2009 21:44:14 +0200
From: Polytropon <freebsd@edvax.de>
To: vogelke+unix@pobox.com
Message-Id: <20090410214414.acc2dc6d.freebsd@edvax.de>
In-Reply-To: <20090410190237.27848BE71@kev.msw.wpafb.af.mil>
References: <70C0964126D66F458E688618E1CD008A0793E92E@WADPEXV0.waddell.com>
	<20090410190237.27848BE71@kev.msw.wpafb.af.mil>
Organization: EDVAX
X-Mailer: Sylpheed 2.4.7 (GTK+ 2.12.1; i386-portbld-freebsd7.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Gary Gatten <ggatten@waddell.com>, freebsd-questions@freebsd.org
Subject: Re: sorta newb help compiling samba
X-BeenThere: freebsd-questions@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Polytropon <freebsd@edvax.de>
List-Id: User questions <freebsd-questions.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-questions>, 
	<mailto:freebsd-questions-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-questions>
List-Post: <mailto:freebsd-questions@freebsd.org>
List-Help: <mailto:freebsd-questions-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-questions>, 
	<mailto:freebsd-questions-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Apr 2009 19:44:23 -0000

Just a small sidenote according to your shell script:

You're defining

	# echo without newline
	necho () {
		echo "$*" | tr -d '\012'
	}

Why don't you use echo -n which suppresses the newline instead
of involving another program to do something that echo can do
on its own? This is how FreeBSD does it in its system scripts.

	echo -n "Starting service... "
	start_service
	echo "done."

And according to 

	test -d /usr/bin || exit 0	# /usr not mounted

Woudln't it be more compliant to exit 1 to signal an error
due to /usr not being mounted? Exit code 0 is usually used
to signal that no error has happened (successful program
run), which isn't the case when the script is not (completely)
run.



-- 
Polytropon
>From Magdeburg, Germany
Happy FreeBSD user since 4.0
Andra moi ennepe, Mousa, ...