From owner-freebsd-bugs@FreeBSD.ORG Mon May 6 04:32:14 2013 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 14D93789; Mon, 6 May 2013 04:32:14 +0000 (UTC) (envelope-from swhetzel@gmail.com) Received: from mail-ie0-x235.google.com (mail-ie0-x235.google.com [IPv6:2607:f8b0:4001:c03::235]) by mx1.freebsd.org (Postfix) with ESMTP id D7FDFE81; Mon, 6 May 2013 04:32:13 +0000 (UTC) Received: by mail-ie0-f181.google.com with SMTP id x12so3555208ief.26 for ; Sun, 05 May 2013 21:32:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=NE+/qQioateCzBePmNVOOCp2Fd+szspq8h4lymtDHbU=; b=lXsWAMSnW8BVnO0Pj9ebWoucKGHyd1bdS+/ELRMSA2XLyAdLiiDKglR/ZvzOjLF6qi EBgk9ONHDSVm2s3/rzZT5SVIw+dMRyg5CVY3snC6XmEe5pxz9K0YZRWaqkBVmXR/N+/P dDro18IuS2px50IB9ft6zK3BWISqFVDC3QRcmd19Dw6IulHoOZCGDTGk9wwJ/nib7+Ts 2pub4FkrJQDOWtfKyNKWWW4uQXDWH1cnwKD8MW3iPGV32GviAtFgqd32eBeHHMTxzp3J SHYqNMG1FE78qTTsU+IwRo7E1tXaPBYxzBLSu4iu8iPRPETa6MdGAEd1HcSnnls9hEYf iaWQ== MIME-Version: 1.0 X-Received: by 10.50.12.133 with SMTP id y5mr2067734igb.108.1367814733533; Sun, 05 May 2013 21:32:13 -0700 (PDT) Received: by 10.50.66.162 with HTTP; Sun, 5 May 2013 21:32:13 -0700 (PDT) In-Reply-To: References: <201305060054.r460sVBh004810@freefall.freebsd.org> Date: Sun, 5 May 2013 23:32:13 -0500 Message-ID: Subject: Re: kern/178359: [geom] [patch] geom_eli: support external metadata From: Scot Hetzel To: freebsd-bugs@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Cc: Andrew Romanenko , freebsd-geom@freebsd.org X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 May 2013 04:32:14 -0000 On Sun, May 5, 2013 at 10:51 PM, Scot Hetzel wrote: > On Sun, May 5, 2013 at 7:54 PM, wrote: >> Old Synopsis: geom_eli: support external metadata >> New Synopsis: [geom] [patch] geom_eli: support external metadata >> >> Responsible-Changed-From-To: freebsd-bugs->freebsd-geom >> Responsible-Changed-By: linimon >> Responsible-Changed-When: Mon May 6 00:54:16 UTC 2013 >> Responsible-Changed-Why: >> Over to maintainer(s). >> >> http://www.freebsd.org/cgi/query-pr.cgi?pr=178359 > > I had a quick look at the patch and noticed that it is using -H for > init method, but -h for the attach, configure, setkey, delkey, resume, > resize, and dump methods. > > The patch also shows that it removes the -h option from the init > method. I looked at the -Current and release/9.1.0 sources for > geom_eli.8 and they don't have the -h option. I suspect it was a > local modification that was made before this patch was created. > My mistake, the -h option was in the geom_eli.c file, but only in the comment for the commands. According to the original commit: https://svnweb.freebsd.org/base?view=revision&revision=148456 The -h was never in the class_commands for the init method. Not sure what it was there for (maybe to display the usuage?). > It would be best that init, attach, configure, setkey, delkey, resume, > resize, and dump methods use the same option (-h or -H) to specify the > headerfile. > So for now it looks like using -H would be the better option for all these methods. -- DISCLAIMER: No electrons were maimed while sending this message. Only slightly bruised.