From owner-freebsd-net  Mon Oct  1  6:37:29 2001
Delivered-To: freebsd-net@freebsd.org
Received: from web12302.mail.yahoo.com (web12302.mail.yahoo.com [216.136.173.100])
	by hub.freebsd.org (Postfix) with SMTP id 019BC37B41A
	for <freebsd-net@FreeBSD.ORG>; Mon,  1 Oct 2001 06:34:19 -0700 (PDT)
Message-ID: <20011001133418.97976.qmail@web12302.mail.yahoo.com>
Received: from [128.107.253.38] by web12302.mail.yahoo.com via HTTP; Mon, 01 Oct 2001 06:34:18 PDT
Date: Mon, 1 Oct 2001 06:34:18 -0700 (PDT)
From: Ravindra Rathi <ravindra_rathi@yahoo.com>
Subject: doubt in radix.c source-code
To: freebsd-net@FreeBSD.ORG
Cc: ravindra_rathi@yahoo.com
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-net.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-net>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-net>
X-Loop: FreeBSD.org

Hi all,
   I am going through the function 
int
rn_walktree (register struct radix_node *rn,
rn_walk_function f, ...)

defined in radix.c file. I have doubt about following
while loop in that function.

/* If at right child go back up, otherwise, go right
*/
while (rn->rn_p->rn_r == rn && (rn->rn_flags &
RNF_ROOT) == 0)
 rn = rn->rn_p;

Looking at the complete function, I think 
(rn->rn_flags & RNF_ROOT) == 0 
check in above while loop is unnecessary. I say this
because of following lines down below in the function.
if (rn->rn_flags & RNF_ROOT) {
  return (0);
}

Am I missing anything? Any insight...?

TIA,
Rathi

__________________________________________________
Do You Yahoo!?
Listen to your Yahoo! Mail messages from any phone.
http://phone.yahoo.com

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message