From owner-svn-src-all@FreeBSD.ORG Fri Jan 30 14:46:32 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 412691065672; Fri, 30 Jan 2009 14:46:32 +0000 (UTC) (envelope-from grafan@gmail.com) Received: from mail-fx0-f13.google.com (mail-fx0-f13.google.com [209.85.220.13]) by mx1.freebsd.org (Postfix) with ESMTP id 94FBA8FC08; Fri, 30 Jan 2009 14:46:27 +0000 (UTC) (envelope-from grafan@gmail.com) Received: by fxm6 with SMTP id 6so48435fxm.19 for ; Fri, 30 Jan 2009 06:46:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=tiyupraK+2ozFgHG1rYsDq+ijzNNNTTsPoDLVV/G1nQ=; b=bva9QnL1laSXAC1Ckx4Wr9UiDXtUba4WOECi3o1pT+x6BgVdsC3BB2212AtvL3sbdC 8rXJNpLT43Niuy/21lIGoayoCQFesfwn8RrT2/xj9Rta9Lwfnllz7mXYeYSLuqMJ546u xX5/vKYCGvN1yeBWHDbm6ekg1x184S1SnVDj4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=wq2IPoNXSay63d3b2hLXbRZxL1L8h+wEkO1G1ZaoRjCD+hRlk/5DwwLEQkJ4rj3rip IFGuIxpWmUwg/3cFrVL/9teXZ6vtXUI7FFLOETV3CL4kwVWesJDeHxqhnHYKV67e129z xrmxqSLVL8gnrAfIw2eRWbui1dNHyweiHDCaE= MIME-Version: 1.0 Received: by 10.181.217.2 with SMTP id u2mr453714bkq.153.1233326784406; Fri, 30 Jan 2009 06:46:24 -0800 (PST) In-Reply-To: <87hc3i8via.fsf@kobe.laptop> References: <200901272013.n0RKDOBR095434@svn.freebsd.org> <6eb82e0901272050l6678ea37idc8ea53e948a15e5@mail.gmail.com> <87r62nnb7t.fsf@kobe.laptop> <6eb82e0901282128o1e38724bsc2dd7a44ebb7de1e@mail.gmail.com> <87hc3i8via.fsf@kobe.laptop> Date: Fri, 30 Jan 2009 22:46:24 +0800 Message-ID: <6eb82e0901300646t220480bdj92e4a3c72e4bdced@mail.gmail.com> From: Rong-en Fan To: Giorgos Keramidas Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r187782 - in head: etc/rc.d share/man/man5 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jan 2009 14:46:32 -0000 On Thu, Jan 29, 2009 at 2:41 PM, Giorgos Keramidas wrote: > On Thu, 29 Jan 2009 13:28:39 +0800, Rong-en Fan wrote: >>>> Shouldn't we keep ntp running after the clock is adjusted? >>> >>> This is correct too. The effect of `ntpd_sync_on_start' is supposed to >>> be the same as if we run `ntpdate' before the real ntpd starts, so this >>> option only applies to the first sync-once instance of ntpd. The real >>> ntpd starts later, and finds the clock pre-synced. >> >> Hmm... I think I'm confused. According to rc.d/ntpd, if ntpd_sync_on_start >> is set to yes, it adds '-q -g' to rc_flags. By doing so, ntpd start makes >> ntpd exists immediately after the first sync. Then, who is responsible >> to start the "real ntpd" you said above? > > Oops, testing with ntpd_sync_on_start again I think I broke rc.d/ntpd. > > I thought precmd was run in _addition_ to the start rc command, but it > only runs before it and affects the flags of start too. I think I'll > back out the change until we the sync on start for real. > > The folowing seems to work much better, but it shows a duplicate message > about `Starting ntpd.' so I have reverted the broken change until I've > worked through the patch a bit more: Hmm... I think your patch here is already good enough. As for the duplicate message, it is unavoidable unless we change rc.subr (like adding a rc_silent). Regards, Rong-En Fan