From owner-freebsd-current@FreeBSD.ORG Tue Aug 10 23:48:10 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 17AEE106566B; Tue, 10 Aug 2010 23:48:10 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-yx0-f182.google.com (mail-yx0-f182.google.com [209.85.213.182]) by mx1.freebsd.org (Postfix) with ESMTP id A96968FC18; Tue, 10 Aug 2010 23:48:09 +0000 (UTC) Received: by yxe42 with SMTP id 42so1531862yxe.13 for ; Tue, 10 Aug 2010 16:48:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:openpgp:content-type:content-transfer-encoding; bh=0hYMl0P/JkKUH26fwU1NkavsQhR8aV0snfKe8at9J9Q=; b=Bf4pBWpHjxM5/UgOkU7RsmYxO3iURL09qCX7JGR8eDOqhPFCU0Fe5k2WW9mBLE1Krl uhjysF6LwSFxk6j2tw29hhRDH6QMXtDWBs6HRDoXKvUoPcyzlvYIsX+7FDVEuxTIipMB SHhD5U6ZSyl4KhptbibIpZJ9iWdx48jhNy1mg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:openpgp:content-type :content-transfer-encoding; b=SnhO8CpzpXqNW46xrRGoae+nWo0j6PN5F3w+xprz/KsYpk+HXivvyKRDgN5q+4PN6F +534WWbUntrwrTMTP+HFSM3r//MUslXDemYq72h84+YZxVmw7AIKkf2Kjb3enpTambqO +21NQWoaHgut8B77v/f2CdGxp6+qvPy+oR+DA= Received: by 10.100.46.17 with SMTP id t17mr20472637ant.237.1281484088689; Tue, 10 Aug 2010 16:48:08 -0700 (PDT) Received: from centel.dataix.local ([99.19.46.227]) by mx.google.com with ESMTPS id i30sm11353411anh.9.2010.08.10.16.48.06 (version=SSLv3 cipher=RC4-MD5); Tue, 10 Aug 2010 16:48:07 -0700 (PDT) Sender: "J. Hellenthal" Message-ID: <4C61E535.3000706@dataix.net> Date: Tue, 10 Aug 2010 19:48:05 -0400 From: jhell User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.2.8) Gecko/20100806 Lightning/1.0b1 Thunderbird MIME-Version: 1.0 To: Adrian Chadd References: In-Reply-To: X-Enigmail-Version: 1.1.2 OpenPGP: id=89D8547E Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-current@freebsd.org, freebsd-stable@freebsd.org Subject: Re: [CFT] if_ath updates - ar5416 (macbook pro, etc) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Aug 2010 23:48:10 -0000 On 08/10/2010 03:58, Adrian Chadd wrote: > On 10 August 2010 15:51, Adrian Chadd wrote: >> Hi everyone, >> >> I'm committing some updates to the if_ath and ath_hal code. >> >> I've just committed updates to the AR5416 register setup values. I'd >> appreciate some testing by AR5416 users - eg macbook pro users - to >> ensure this hasn't broken functionality. > > I've also started merging in general if_ath changes; so please test > the ath code in -head and let me know if I've introduced any > regressions. > I have applied the following (r211136) to my local stable/8 branch and has proven to be an improvement with no drawbacks. diff -r 7d9664d4ac99 sys/dev/ath/if_ath.c --- a/sys/dev/ath/if_ath.c Tue Aug 10 16:41:55 2010 -0400 +++ b/sys/dev/ath/if_ath.c Tue Aug 10 19:39:25 2010 -0400 @@ -5418,6 +5418,7 @@ longCal = (ticks - sc->sc_lastlongcal >= ath_longcalinterval*hz); if (longCal) { sc->sc_stats.ast_per_cal++; + sc->sc_lastlongcal = ticks; if (ath_hal_getrfgain(ah) == HAL_RFGAIN_NEED_CHANGE) { /* * Rfgain is out of bounds, reset the chip @@ -5466,7 +5467,6 @@ nextcal *= 10; } else { nextcal = ath_longcalinterval*hz; - sc->sc_lastlongcal = ticks; if (sc->sc_lastcalreset == 0) sc->sc_lastcalreset = sc->sc_lastlongcal; else if (ticks - sc->sc_lastcalreset >= ath_resetcalinterval*hz) As for the rest I can not vouch for unless you give me a specific patch to test but I am willing to merge from head to my local tree at any given point in time if you can give some revisions you would like tested. You "I believe" made it possible for me to use this card within a week that I had reported it ~2007-2008 so I and my card are at your disposal. Thank you. -- jhell,v