From owner-freebsd-mips@freebsd.org Sat Jan 23 05:18:06 2016 Return-Path: Delivered-To: freebsd-mips@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0BC7DA8D191; Sat, 23 Jan 2016 05:18:06 +0000 (UTC) (envelope-from sgalabov@gmail.com) Received: from mail-vk0-x22e.google.com (mail-vk0-x22e.google.com [IPv6:2607:f8b0:400c:c05::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C7B2F1AA5; Sat, 23 Jan 2016 05:18:05 +0000 (UTC) (envelope-from sgalabov@gmail.com) Received: by mail-vk0-x22e.google.com with SMTP id k1so51600792vkb.2; Fri, 22 Jan 2016 21:18:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=mW2+HkIiGk3UWA0BewHg1xEaK/1Kys/ivg19mTZm5dc=; b=m1f/BySZ0ACWkuGzJTVSWJRcx2U5kTQEB34tcfFLo6HPaZ5sWGlcw+3ZTBiQXxvMHs E8vH7WbcqIqD7/4xBzSIC7EFR82iH4bgQwLeWNNT8F4qM85QxPcuyAmadaXVvWmJlVGa gJGC97O2LkpjMR6m678fSPmGyPOHp6wGc9uXP8LL6/bmDS6XWlWYTkiD8PbqVSYen8S/ xnmy21RX+NTeuayZ66WgrCdcnoV/nLLotgcnZOQ4oPU3z1tghtfnuwy4m4037tFUvkUn BAbCnFFUzmLgD+PK/yE2Y0jlunxO8Cw5bljdHTVMleiNflFJMdUvPS0DKtQYpl82C5Pl SPUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=mW2+HkIiGk3UWA0BewHg1xEaK/1Kys/ivg19mTZm5dc=; b=Bggbiiu06CUSF1inwqreDbzeEQgSLNKlJ6qdDX37LQeO+dfqP6LyTyxPKs6r1IIymI 5VSZ1z4wE99hj7Ra7RZcqgrPBPxGoZkNCnkkeXTrbimQf9+hq9/ZlQTtKe3SK2aoY7N5 Hd0VI8HYxbakrPUT1YH0xF5s0jZ00pkBCHxatlBIiscoxpVaPQfu1VXirGNr2dfhxMry zHB8AQ7r9AbeqvZ6ZV4liFOtwWZ0dC59UHb38jR7hiGfcm8cFOrGeR8EYlBozBNZc0oh +WITMPe7V0vEyzMfeTSF/8eA7iKJXRdvn6EVIoA6/BvoJLPySx4I209ZaDbdoEj2Uv7N /NKQ== X-Gm-Message-State: AG10YOQCVZ3KIbtYClmk45r3UYHJAxa8g42LRG5QZIAK98T474YNYcXzTrSBXENCxsPPI+paz+fA0qKT3MTFfA== MIME-Version: 1.0 X-Received: by 10.31.153.11 with SMTP id b11mr4295738vke.127.1453526284881; Fri, 22 Jan 2016 21:18:04 -0800 (PST) Received: by 10.31.183.147 with HTTP; Fri, 22 Jan 2016 21:18:04 -0800 (PST) In-Reply-To: <20160122173906.147bb7c2@stevek-ubuntu.jnpr.net> References: <20160122173906.147bb7c2@stevek-ubuntu.jnpr.net> Date: Sat, 23 Jan 2016 07:18:04 +0200 Message-ID: Subject: Re: SPI geom_flashmap/fdt_slicer support, FDT 'resets=' support and a move of ohci_fdt.c From: Stanislav Galabov To: Steve Kiernan Cc: freebsd-mips@freebsd.org, freebsd-arm@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jan 2016 05:18:06 -0000 It looks like only part of the original patch I submitted made it into head (only the mx25l part). We also need to change sys/conf/files as Steve pointed out, as well as sys/geom/geom_flashmap.c: https://bz-attachments.freebsd.org/attachment.cgi?id=3D165546 Best wishes, Stanislav On Sat, Jan 23, 2016 at 12:39 AM, Steve Kiernan wrote: > On Thu, 14 Jan 2016 11:01:10 +0200 > Stanislav Galabov wrote: > > > Hi all, > > > > First off, sorry for the cross-post, I wasn=E2=80=99t very sure where t= his > should go=E2=80=A6 > > > > I=E2=80=99ve created 3 PRs, which enable some functionality that my wor= k on > Ralink/Mediatek SoCs would benefit from. > > > > 1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D206227 > > - This enables geom_flashmap and fdt_slicer support for SPI flash chips > supported by the mx25l driver (sys/dev/flash/mx25l.c) > > I see this change was committed to head, but I don't see a corresponding > change to sys/conf/files to ensure fdt_slicer.c and geom_flashmap.c get > compiled. > > I think you also need something like the following: > > Index: sys/conf/files > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/conf/files (revision 294541) > +++ sys/conf/files (working copy) > @@ -1419,7 +1419,7 @@ > dev/fdt/fdt_common.c optional fdt > dev/fdt/fdt_pinctrl.c optional fdt fdt_pinctrl > dev/fdt/fdt_pinctrl_if.m optional fdt fdt_pinctrl > -dev/fdt/fdt_slicer.c optional fdt cfi | fdt nand > +dev/fdt/fdt_slicer.c optional fdt cfi | fdt nand | fdt mx25l > dev/fdt/fdt_static_dtb.S optional fdt fdt_dtb_static \ > dependency "$S/boot/fdt/dts/${MACHINE}/${FDT_DTS_FILE}" > dev/fdt/simplebus.c optional fdt > @@ -3010,7 +3010,7 @@ > geom/geom_dump.c stfgeom_dumandard > geom/geom_event.c standard > geom/geom_fox.c optional geom_fox > -geom/geom_flashmap.c optional fdt cfi | fdt nand > +geom/geom_flashmap.c optional fdt cfi | fdt nand | fdt mx25l > geom/geom_io.c standard > geom/geom_kern.c standard > geom/geom_map.c optional geom_map >