From owner-freebsd-rc@FreeBSD.ORG Sun Aug 21 11:28:55 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 33A6D106566B; Sun, 21 Aug 2011 11:28:55 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-iy0-f172.google.com (mail-iy0-f172.google.com [209.85.210.172]) by mx1.freebsd.org (Postfix) with ESMTP id BCB978FC08; Sun, 21 Aug 2011 11:28:54 +0000 (UTC) Received: by iye7 with SMTP id 7so16546312iye.17 for ; Sun, 21 Aug 2011 04:28:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=EWcIFhx24Lj3NVOY56CJHujCk6UL2Fz4WI5KUqe71UA=; b=lAbheTjfW8wXvwCox4qtJpzWbiW4B275VH491O3z5QmLqTesjQSJZPaqXTr9cwzJfU LJWYWs9z1xOw4h2YKhcImsgmCOTZM/vVSlpafAxG5riN6bfa4d606U44zSixi/FnFtWi rsNZLJe3N3Wu9ycJqwCydiq7gkV9sRiywjzC8= Received: by 10.42.141.5 with SMTP id m5mr1473748icu.482.1313926134062; Sun, 21 Aug 2011 04:28:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.182.77 with HTTP; Sun, 21 Aug 2011 04:28:24 -0700 (PDT) In-Reply-To: <4E5041CA.3030108@FreeBSD.org> References: <4E5041CA.3030108@FreeBSD.org> From: Chris Rees Date: Sun, 21 Aug 2011 12:28:24 +0100 Message-ID: To: Doug Barton Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-rc@freebsd.org, Colin Percival Subject: Re: RC script for spiped (cperciva's latest invention) X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Aug 2011 11:28:55 -0000 On 21 August 2011 00:22, Doug Barton wrote: > On 08/20/2011 02:41, Chris Rees wrote: >> Hi all, >> >> Colin's submitted a port for his spiped program, with an rc script and >> I figure I should get it reviewed after my tweaks. >> >> Please refer to [1] for the provisional file, and the original PR is at = [2]. >> >> Thanks! >> >> Chris >> >> [1] http://www.bayofrum.net/~crees/patches/spiped-rc-script >> >> [2] http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/159899 > > Attached is a patch that includes a couple of minor style issues, and > more importantly local'izing the variables used in the functions. > Otherwise it looks good to me. > > > hth, > > Doug Very much appreciated. Thanks! Chris --=20 Chris Rees =A0 =A0 =A0 =A0 =A0| FreeBSD Developer crees@FreeBSD.org =A0 | http://people.freebsd.org/~crees