From owner-svn-src-all@FreeBSD.ORG Thu Jan 23 10:11:09 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 94E4E9C2; Thu, 23 Jan 2014 10:11:09 +0000 (UTC) Received: from mta05.bitpro.no (mta05.bitpro.no [92.42.64.202]) by mx1.freebsd.org (Postfix) with ESMTP id 43F7E1ADB; Thu, 23 Jan 2014 10:11:09 +0000 (UTC) Received: from mail.lockless.no (mail.lockless.no [46.29.221.38]) by mta05.bitpro.no (Postfix) with ESMTPS id 8A64717FC8E; Thu, 23 Jan 2014 11:11:07 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail.lockless.no (Postfix) with ESMTP id A2E121607AF; Thu, 23 Jan 2014 11:11:57 +0100 (CET) X-Virus-Scanned: by amavisd-new-2.6.4 (20090625) (Debian) at lockless.no Received: from mail.lockless.no ([127.0.0.1]) by localhost (mail.lockless.no [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V5wVqcxXtxxU; Thu, 23 Jan 2014 11:11:56 +0100 (CET) Received: from laptop015.home.selasky.org (cm-176.74.213.204.customer.telag.net [176.74.213.204]) by mail.lockless.no (Postfix) with ESMTPSA id 97DDC160758; Thu, 23 Jan 2014 11:11:56 +0100 (CET) Message-ID: <52E0EAF9.5080406@bitfrost.no> Date: Thu, 23 Jan 2014 11:12:09 +0100 From: Hans Petter Selasky Organization: Bitfrost A/S User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Kevin Lo Subject: Re: svn commit: r261014 - head/sys/dev/usb/wlan References: <201401220957.s0M9vQfY070899@svn.freebsd.org> <52E0E36E.2070509@FreeBSD.org> In-Reply-To: <52E0E36E.2070509@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jan 2014 10:11:09 -0000 On 01/23/14 10:39, Kevin Lo wrote: > > On 2014/01/22 17:57, Hans Petter Selasky wrote: >> Author: hselasky >> Date: Wed Jan 22 09:57:26 2014 >> New Revision: 261014 >> URL: http://svnweb.freebsd.org/changeset/base/261014 >> >> Log: >> - Fix some non-portable code with regard to endianness. Don't use >> memmove(). >> - Fix a range check for maximum transmit length. >> - Fix read from missing field when transmitting data. >> MFC after: 2 weeks > > I appreciate you're taking the time to fix code, but your change totally > breaks RT3573 and IQ calibration doesn't work for RT5372 and RT5572. > I think it'd be good to send me the patch for testing/review > before committing. Thanks! > > Kevin > > Hi Kevin, That's fine. I don't have that chipset to test with. My dongle was working fine with the given patches. The fixes were based on code inspection. Will you send a new patch to fix the issues I've mentioned today? There are clearly some bugs in there either with or without the patch. Thank you! --HPS