From owner-svn-src-all@FreeBSD.ORG  Wed Dec 24 22:26:51 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 6EC99198;
 Wed, 24 Dec 2014 22:26:51 +0000 (UTC)
Received: from nibbler.fubar.geek.nz (nibbler.fubar.geek.nz [199.48.134.198])
 by mx1.freebsd.org (Postfix) with ESMTP id 52A6764DC9;
 Wed, 24 Dec 2014 22:26:51 +0000 (UTC)
Received: from bender (unknown [213.205.252.212])
 by nibbler.fubar.geek.nz (Postfix) with ESMTPSA id A5D5F7328F;
 Wed, 24 Dec 2014 22:26:43 +0000 (UTC)
Date: Wed, 24 Dec 2014 22:26:37 +0000
From: Andrew Turner <andrew@fubar.geek.nz>
To: Ian Lepore <ian@FreeBSD.org>
Subject: Re: svn commit: r276187 - head/sys/arm/arm
Message-ID: <20141224222637.03a19e57@bender>
In-Reply-To: <201412241712.sBOHCqvW039381@svn.freebsd.org>
References: <201412241712.sBOHCqvW039381@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Dec 2014 22:26:51 -0000

On Wed, 24 Dec 2014 17:12:52 +0000 (UTC)
Ian Lepore <ian@FreeBSD.org> wrote:

> Author: ian
> Date: Wed Dec 24 17:12:51 2014
> New Revision: 276187
> URL: https://svnweb.freebsd.org/changeset/base/276187
> 
> Log:
>   Eliminate unnecessary references to pte.h internals by using the
> standard pmap_kenter_temporary() to map pages while dumping.
>   
>   Submitted by:	Svatopluk Kraus <onwahe@gmail.com>,
>   		Michal Meloun <meloun@miracle.cz>
> 
> Modified:
>   head/sys/arm/arm/dump_machdep.c
> 
> Modified: head/sys/arm/arm/dump_machdep.c
> ==============================================================================
> --- head/sys/arm/arm/dump_machdep.c	Wed Dec 24 16:11:15
> 2014	(r276186) +++ head/sys/arm/arm/dump_machdep.c	Wed
> Dec 24 17:12:51 2014	(r276187) @@ -160,11 +160,13 @@ static int
>  cb_dumpdata(struct md_pa *mdp, int seqnr, void *arg)
>  {
>  	struct dumperinfo *di = (struct dumperinfo*)arg;
> -	vm_paddr_t pa;
> +	vm_paddr_t a, pa;
> +	void *va;
>  	uint32_t pgs;
>  	size_t counter, sz, chunk;
> -	int c, error;
> +	int i, c, error;
>  
> +	va = 0;
>  	error = 0;	/* catch case in which chunk size is 0 */
>  	counter = 0;
>  	pgs = mdp->md_size / PAGE_SIZE;
> @@ -194,16 +196,14 @@ cb_dumpdata(struct md_pa *mdp, int seqnr
>  			printf(" %d", pgs * PAGE_SIZE);
>  			counter &= (1<<24) - 1;
>  		}
> -		if (pa == (pa & L1_ADDR_BITS)) {
> -			pmap_kenter_section(0, pa & L1_ADDR_BITS, 0);
> -			cpu_tlb_flushID_SE(0);
> -			cpu_cpwait();
> +		for (i = 0; i < chunk; i++) {
> +			a = pa + i * PAGE_SIZE;
> +			va = pmap_kenter_temporary(trunc_page(a), i);

Is this correct? It may map multiple chunks here.
>  		}
>  #ifdef SW_WATCHDOG
>  		wdog_kern_pat(WD_LASTVAL);
>  #endif
> -		error = dump_write(di,
> -		    (void *)(pa - (pa & L1_ADDR_BITS)),0, dumplo,
> sz);
> +		error = dump_write(di, va, 0, dumplo, sz);

Then uses the last virtual address to dump the data here. Wouldn't this
miss the chunks mapped other than the last one?

Andrew